General

Profile

Viktor Pec

Issues

Projects

Activity

04/15/2020

03:25 PM LArSoft Bug #24318: larreco/RecoAlg/TrajClusterAlg: Unchecked loop range leads to seg fault
I am not sure what the best fix for this is. I am not familiar with how the whole tool works.
A simple patch woul...
10:56 AM LArSoft Bug #24318 (Closed): larreco/RecoAlg/TrajClusterAlg: Unchecked loop range leads to seg fault
In larreco/RecoAlg/TrajClusterAlg
https://github.com/LArSoft/larreco/blob/cf6057b3f8b2ea14cacd7d1df2241eace4ce9252...

11/20/2019

06:35 AM LArSoft Bug #23605: Potential infinite loop in PFPUtils.cxx
I have removed the feature branch. I think this ticket can be closed.
05:13 AM LArSoft Bug #23605: Potential infinite loop in PFPUtils.cxx
To summarise from my side:
I created a feature branch larreco@feature/vpec_pfputils_types_fix and modified @PFPUtils...

11/19/2019

01:20 PM LArReco Revision d2efc527: Fourth iteration of fixing iterator types. Additional replacement of @unsigned int@ and @short@ defs for variables used as iterators, wherever they were compared to the output of a @size()@.
12:58 PM LArReco Revision 306dcf32: Third iteration of fixing iterator types. Replaced @unsigned int@ and @short@ definition of loop iterators wherever they were compared to the output of a @size() - 1@.
12:52 PM LArReco Revision dd52d95e: Second iteration of fixing iterator types. Replaced @unsigned int@ definition of loop iterators wherever they were compared to the output of a @size()@ method.
12:47 PM LArReco Revision e6fdc894: First iteration of fixin iterator types. Replaced @unsigned short@ definition of loop iterators wherever they were compared to the output of a @size()@ method.
12:03 PM LArSoft Bug #23605: Potential infinite loop in PFPUtils.cxx
If "evaluated individually" meant simply making sure that there's mismatch in types in the comparisons of the iterato...
07:45 AM LArSoft Bug #23605 (Accepted): Potential infinite loop in PFPUtils.cxx
Fix pushed to develop, larreco:commit:0f40d2fd.
One thing to note here is that there are many instances of simil...

Also available in: Atom