Project

General

Profile

Code Review Meeting Notes


October 28, 2019

Marco Mambelli, Marco Mascheroni, Dennis Box, Lorena Lobato Pardavila, Bruno Coimbra

Discussion
  • Reviewed development workflow and main branches used, to explain to Bruno
  • It is the general consensus among the team that Github would be a better platform for the main repository. The FNAL one will become the mirror in read-only
  • Debugging suggestions from Marco Mascheroni:
    • run everything from the shell, put breakpoints
    • start main process and subprocesses separately,
  • We are re-designing in part the system
    • think about changes that could make debugging easier
    • Marco Mascheroni: option not to have master as a daemon, stopping before popen and printing commands before spawning subprocesses
Code review of Dennis code about token-auth
  • Changes suggested
    • verify also token (no skipping)
    • condor configuration should be created in condor_startup.sh, not included in the Frontend attrs (OK only for prototyping)
    • GWMS should by default use token auth if all is OK for it (condor version, token, ...) otherwise fall back to x509. No need for user configuration on this
TODO:
  • Marco Mambelli:
    • Migrating to GitHub
  • Marco Mascheroni:
    • Send an email or write a wiki note w/ debugging/troubleshooting suggestions
  • Dennis:
    • Make sure that OSG 3.5 condor is OK w/ GlideinWMS
  • Everyone:
    • write one unit test

August 20, 2019

Marco Mambelli, Marco Mascheroni, Dennis Box, Lorena Lobato Pardavila, Leonardo Lai

  • Outcome
    • We have covered all the points.
  • Keep working in Python constructs when possible:

June 25, 2019

Marco Mambelli, Marco Mascheroni, Dennis Box, Lorena Lobato Pardavila

  • Branch: review20190625
  • Meeting room: WH8XO
  • Tentative Agenda:
    • TBA
  • Outcome
    • We were working mostly in pep8 improvements
  • TODO Next:
    • N/A