Project

General

Profile

Necessary Maintenance #9879

Introduce deprecations for ParameterSet::get_keys and ParameterSet::get_pset_keys

Added by Kyle Knoepfel over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
08/24/2015
Due date:
% Done:

100%

Estimated time:
2.00 h
Spent time:
Scope:
Internal
Experiment:
-
SSI Package:
fhicl-cpp
Duration:

Description

The following functions should be deprecated in fhicl-cpp, per stakeholder discussion:
  • ParameterSet::get_keys()
  • ParameterSet::get_pset_keys()
in favor of the new functions:
  • ParameterSet::get_names()
  • ParameterSet::get_pset_names()

A helpful warning message should be printed at compile time whenever a call is made to one of the deprecated functions.


Related issues

Blocked by cet-is - Feature #9881: New option ALLOW_DEPRECATIONS to cetbuildtools set_compiler_flags()Closed08/25/2015

History

#1 Updated by Christopher Green over 4 years ago

  • Blocked by Feature #9881: New option ALLOW_DEPRECATIONS to cetbuildtools set_compiler_flags() added

#2 Updated by Christopher Green over 4 years ago

  • Status changed from New to Accepted

#3 Updated by Kyle Knoepfel over 4 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

Implemented with commits fhicl-cpp:cc59075e and fhicl-cpp:6e077b9a. The deprecation diagnostic messages triggered at compile time are:

# get_keys diagnostic

fhiclcpp warning: The 'fhicl::ParameterSet::get_keys()' function is deprecated.
Please use 'fhicl::ParameterSet::get_names()'.

and

# get_pset_keys diagnostic

fhiclcpp warning: The 'fhicl::ParameterSet::get_pset_keys()' function is deprecated.
Please use 'fhicl::ParameterSet::get_pset_names()'.

#4 Updated by Kyle Knoepfel over 4 years ago

  • Target version set to 1.18.00

#5 Updated by Kyle Knoepfel over 4 years ago

  • Target version changed from 1.18.00 to 1.16.00

#6 Updated by Christopher Green over 4 years ago

  • Tracker changed from Necessary Maintenance to Feature
  • Project changed from cet-is to art
  • Category set to Infrastructure

#7 Updated by Christopher Green over 4 years ago

  • Status changed from Resolved to Assigned

#8 Updated by Christopher Green over 4 years ago

  • Tracker changed from Feature to Bug
  • Status changed from Assigned to Resolved

#9 Updated by Christopher Green over 4 years ago

  • Tracker changed from Bug to Necessary Maintenance
  • Project changed from art to cet-is
  • Category deleted (Infrastructure)

#10 Updated by Christopher Green over 4 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF