Bug #9705
Temporary workaround on optical detector code in larana should be removed for a real fix
Description
OpticalDetector/OpFlashFinder_module.cc has a temporary workaround while waiting for the real fix.
Related commit larana:a24808af918bf7e1523c320d556068e314dd2b6d .
Associated revisions
History
#1 Updated by Gianluca Petrillo over 5 years ago
A feature branch has been merged in v04_17_00 that fixes the issue.
Nevertheless, a suspicious line sporting the same code as the unfixed one is present, one line above the fixed one.
#2 Updated by Gianluca Petrillo over 4 years ago
- Subject changed from Temporary fworkaround on optical detector code in larana should be removed for a real fix to Temporary workaround on optical detector code in larana should be removed for a real fix
#3 Updated by Gianluca Petrillo over 4 years ago
- Description updated (diff)
#4 Updated by Gianluca Petrillo over 4 years ago
I suspect that the issue was resolved long time ago with larana:f1381b241edf5d27a0d9b5c0f5c921cb079474ac .
Yet, the code still shows the workaround warning. That should be removed before the issue is marked as resolved.
#5 Updated by Gianluca Petrillo over 4 years ago
Taritree confirms that commit larana:f1381b241edf5d27a0d9b5c0f5c921cb079474ac solved the issue long time ago.
Commit larana:bb5e99ea881c564551f23b7bb42b65932357c838 removes the outdated comment.
#6 Updated by Gianluca Petrillo over 4 years ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
- Experiment LArSoft added
- Experiment deleted (
-)
#7 Updated by Katherine Lato over 4 years ago
- Status changed from Resolved to Closed
Removed outdated comment.
This completes the solution of issue #9705 .