Project

General

Profile

Bug #8681

fetchlog failure for cdms group

Added by Dennis Box almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
05/08/2015
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

see INC000000538346. I forgot to create a ticket for this, it is a reproducible problem.

Dennis

History

#1 Updated by Dennis Box almost 6 years ago

  • Status changed from New to Feedback
  • Assignee changed from Dennis Box to Parag Mhashilkar

see branch 8681

#2 Updated by Parag Mhashilkar almost 6 years ago

  • Target version changed from v1.1.2 to v1.1.3

#3 Updated by Parag Mhashilkar almost 6 years ago

  • Target version changed from v1.1.3 to v1.1.2

#4 Updated by Parag Mhashilkar almost 6 years ago

  • Assignee changed from Parag Mhashilkar to Dennis Box

Most of the code looks ok. Minor suggestion to save one operation. For checking if dict or array is not empty, you can avoid one call to len() and directly use if foo: You have this in code at couple of places.
Should be ok to merge with this changes

def check(foo):
     if foo:
         return 'Not empty'
     return 'Empty'

print check([])
Empty

print check([1])
Not empty

#5 Updated by Parag Mhashilkar almost 6 years ago

  • Status changed from Feedback to Resolved

#6 Updated by Parag Mhashilkar almost 6 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF