Project

General

Profile

Bug #8544

Undo doesn't Work

Added by Michael Wren almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Low
Target version:
Start date:
04/30/2015
Due date:
% Done:

0%

Estimated time:
3.00 h
Spent time:
Duration:

Description

Undo doesn't Work

But it's a bit more subtle than that. R3 will undo any unsent changes, but most other programs the undo takes you back to a setting where you were when you entered the event sub-page. For tuning, the way the other programs work is best, as if you made a bad change you can click undo and send to put the machine back.

https://www-bd.fnal.gov/Elog/?entryIDs=28813

History

#1 Updated by Kyle Hazelwood almost 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Kyle Hazelwood
  • Priority changed from Normal to Low
  • Estimated time set to 3.00 h

It turns out only the hv.cpp (The Anode Program curve page) does this. The other pages driven by hl.cpp work as expected.

Change hv.cpp 274-278 for the anode program page so that it calls label re_disp: (not new_file:). re_disp can be copied from chro.cpp in PA4208 (R2) with minor changes. Add re_disp to line ~150 in hv.cpp. re_disp: just deletes the window and forces a reload of the window.

Alter:

else if (ibar == 6) {         //Undo 
     /* restore original only  */
     memcpy(&cs,&cs_back,sizeof(CS_HV_TABLE));
     goto new_file;
}

Add:
re_disp:
if (wn) {
    window_menu_bar_delete_c(wn);
    del_window(&wn); 
}

#2 Updated by Kyle Hazelwood almost 4 years ago

  • Target version set to 1.1

#3 Updated by Kyle Hazelwood almost 4 years ago

  • Status changed from Assigned to Closed

Released



Also available in: Atom PDF