Necessary Maintenance #8427
Remove unnecessary data mamber from art::EventID
Description
EventID has an erroneous data member, run_, whose information is redundant with that contained by the SubRunID, subRun_. While it is not used, its presence and exposure in the interface (via static flushEvent(RunID, SubRunID)) allows for misunderstandings and errors due to the possibility of inconsistency of information between run_ and subRun_.
run_ should be removed as a data member and the member function at issue should be superseded by one without an explicit RunID in the interface and removed or deprecated.
Related issues
Associated revisions
History
#1 Updated by Christopher Green over 5 years ago
- Related to Feature #4946: art memory use: multiple subruns added
#2 Updated by Christopher Green over 5 years ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
Implemented with b951848.
The time spent, above, includes that spent producing upgrade feature branches for the artdaq-core and artdaq projects which will allow the building of the same source code against old and new versions of the art::EventID interface.
#3 Updated by Christopher Green over 5 years ago
- Project changed from cet-is to art
- Subject changed from Remove unnecessarydata mamber from art::EventID to Remove unnecessary data mamber from art::EventID
#4 Updated by Christopher Green over 5 years ago
- Related to Feature #8441: Changes necessary to build against art Canopus while continuing to support older art versions added
#5 Updated by Kyle Knoepfel over 5 years ago
- Status changed from Resolved to Closed
Implement issue #8427.