Project

General

Profile

Necessary Maintenance #8178

Testing of drop on input needs improvement

Added by Marc Paterno over 4 years ago. Updated about 2 years ago.

Status:
Accepted
Priority:
Low
Assignee:
-
Category:
I/O
Target version:
-
Start date:
03/25/2015
Due date:
% Done:

0%

Estimated time:
8.00 h
Scope:
Experiment:
SSI Package:
Duration:

Description

I was looking at some of the code we have for doing “drop on input” using our Root source. I come to wondering if I could modify some of this code. First, I did a simple check to see if our testing was complete enough. I think it is not, but it is rather complex and I don’t have time to look into it now. I don’t want to submit this as a bug report, because there may not be a bug in the code, just insufficient testing.

What I did, and what I would like to have caused a test failure, is to modify the function RootInputFile::dropOnInput. In the code:

 if (dropDescendants) {
   branchChildren_->appendToDescendants(prod.branchID(), branchesToDrop);
 } else {
   branchesToDrop.insert(prod.branchID());
 }

I commented out the body of the ‘else’ clause. I rebuilt the code, ran the tests… and all the tests pass. My reading of this is that the tests for drop on input don’t actually verify that the product that is supposed to have been dropped has actually been dropped. I also tried replacing call in the else cause with “throw 3”. The tests again all pass… no exception is thrown. It appears that ‘dropDescendants’ is never false an any test.

History

#1 Updated by Christopher Green over 4 years ago

  • Category set to I/O
  • Status changed from New to Accepted
  • Priority changed from Normal to Low
  • Estimated time set to 8.00 h

#2 Updated by Kyle Knoepfel over 4 years ago

  • Target version set to 521

#3 Updated by Kyle Knoepfel about 2 years ago

  • Target version deleted (521)


Also available in: Atom PDF