Project

General

Profile

Support #8104

Support #8103: Update to art 1.13.01: update deprecated features

Fix the services.user directive in art FHiCL configuration files

Added by Gianluca Petrillo over 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Low
Category:
Other
Target version:
-
Start date:
03/17/2015
Due date:
% Done:

100%

Estimated time:
Spent time:
Experiment:
-
Co-Assignees:
Duration:

Description

The new art version 1.13 brings some deprecations.
This one is about the configuration of user services.
They used to be defined in the services.user parameter set, now is moved into services instead.

Associated revisions

Revision ff667a18 (diff)
Added by Gianluca Petrillo about 3 years ago

Removed the "user" level of service configuration (issue #8104)

Revision c7dcfc9d (diff)
Added by Gianluca Petrillo about 3 years ago

Removed the "user" level of service configuration (issue #8104)

Revision 332a3cf3 (diff)
Added by Gianluca Petrillo about 3 years ago

Removed the "user" level of service configuration (issue #8104)

Revision 0ae82ef4 (diff)
Added by Gianluca Petrillo about 3 years ago

Removed the "user" level of service configuration (issue #8104)

Revision d3b72a1f (diff)
Added by Gianluca Petrillo about 3 years ago

Removed the "user" level of service configuration (issue #8104)

Revision 5a092052 (diff)
Added by Michael Wallbank about 3 years ago

Removed the "user" level of service configuration (issue #8104)

Revision d9dfa71e (diff)
Added by Lynn Garren about 3 years ago

Removed the "user" level of service configuration (issue #8104)

Revision f05989ab
Added by Gianluca Petrillo about 3 years ago

Do-it-yourself part of resolution of issue #8104

Merge branch 'feature/gp_Issue8103' into develop

History

#1 Updated by Lynn Garren over 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Gianluca Petrillo

Art would like to move the location of user service configuration in the next release.

#2 Updated by Gianluca Petrillo about 4 years ago

Fixed FHiCL files have been uploaded on branch feature/gp_Issue8103 (because I looked up the wrong issue number) of the following repositories:
- LArSoft: lardata, larevt, larsim, larreco, larana, larpandora, lareventdisplay, larexamples, larsoft
- experiments: argoneutcode, lariatsoft, lbnecode, uboonecode

A few FHiCL files in lbnecode and uboonecode have a construct like:

services.user: @local::my_services

that I don't know how to translate into the new paradigm yet.

#3 Updated by Gianluca Petrillo about 4 years ago

  • % Done changed from 0 to 90

#4 Updated by Gianluca Petrillo about 3 years ago

One year later, the FHiCL @table:: construct well established, the work can be completed.
I did everything again from scratch, and wrote a replacement script RemoveUserFromServiceConfig.py (in larsoft/bin) that can address most of the substitutions and warns about possible other places to be changed by hand.

Changes have been pushed in LArSoft repositories as branch feature/gp_Issue8103: lardata, larevt, larsim, larreco, larpandora, larana, lareventdisplay and larsoft.

Experiment repositories have not been updated. Running RemoveUserFromServiceConfig.py -Uv in them show that after the automated substitutions, some replacements are left to be done manually.
The following table shows that dunetpc and lariatsoft will not need manual changes (although the script will suggest some to dunetpc):

repository manual actions wrong warnings
argoneutcode 1
dunetpc 5
lariatsoft
uboonecode 12

The manual intervention consists in removing the opening and closing line of the user table:

services: {
  user: {    ### DELETE THIS LINE
    # ...
  }          ### DELETE THIS LINE
}

#5 Updated by Gianluca Petrillo about 3 years ago

  • Status changed from Assigned to Resolved

#6 Updated by Gianluca Petrillo about 3 years ago

  • % Done changed from 90 to 100

#7 Updated by Gianluca Petrillo about 3 years ago

Approval tracking:

MicroBooNE approved (20160906, Herbert Greenlee)
DUNE did not give a time yet
LArIAT approved (20160816, Brian Rebel)
ArgoNeuT did not give a time yet

SBND is not in sync with LArSoft develop, but they have already started this migration.

#8 Updated by Gianluca Petrillo almost 3 years ago

Herbert Greenlee has communicated MicroBooNE's approval for this change.

#9 Updated by Gianluca Petrillo almost 3 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF