Support #8104
Support #8103: Update to art 1.13.01: update deprecated features
Fix the services.user directive in art FHiCL configuration files
Description
The new art
version 1.13 brings some deprecations.
This one is about the configuration of user services.
They used to be defined in the services.user
parameter set, now is moved into services
instead.
Associated revisions
Removed the "user" level of service configuration (issue #8104)
Removed the "user" level of service configuration (issue #8104)
Removed the "user" level of service configuration (issue #8104)
Removed the "user" level of service configuration (issue #8104)
Removed the "user" level of service configuration (issue #8104)
Removed the "user" level of service configuration (issue #8104)
Do-it-yourself part of resolution of issue #8104
Merge branch 'feature/gp_Issue8103' into develop
History
#1 Updated by Lynn Garren almost 6 years ago
- Status changed from New to Assigned
- Assignee set to Gianluca Petrillo
Art would like to move the location of user service configuration in the next release.
#2 Updated by Gianluca Petrillo over 5 years ago
Fixed FHiCL files have been uploaded on branch feature/gp_Issue8103
(because I looked up the wrong issue number) of the following repositories:
- LArSoft: lardata
, larevt
, larsim
, larreco
, larana
, larpandora
, lareventdisplay
, larexamples
, larsoft
- experiments: argoneutcode
, lariatsoft
, lbnecode
, uboonecode
A few FHiCL files in lbnecode
and uboonecode
have a construct like:
services.user: @local::my_services
that I don't know how to translate into the new paradigm yet.
#3 Updated by Gianluca Petrillo over 5 years ago
- % Done changed from 0 to 90
#4 Updated by Gianluca Petrillo over 4 years ago
One year later, the FHiCL @table::
construct well established, the work can be completed.
I did everything again from scratch, and wrote a replacement script RemoveUserFromServiceConfig.py
(in larsoft/bin
) that can address most of the substitutions and warns about possible other places to be changed by hand.
Changes have been pushed in LArSoft repositories as branch feature/gp_Issue8103
: lardata
, larevt
, larsim
, larreco
, larpandora
, larana
, lareventdisplay
and larsoft
.
Experiment repositories have not been updated. Running RemoveUserFromServiceConfig.py -Uv
in them show that after the automated substitutions, some replacements are left to be done manually.
The following table shows that dunetpc
and lariatsoft
will not need manual changes (although the script will suggest some to dunetpc
):
repository | manual actions | wrong warnings |
argoneutcode |
1 | |
dunetpc |
5 | |
lariatsoft |
||
uboonecode |
12 |
The manual intervention consists in removing the opening and closing line of the user
table:
services: { user: { ### DELETE THIS LINE # ... } ### DELETE THIS LINE }
#5 Updated by Gianluca Petrillo over 4 years ago
- Status changed from Assigned to Resolved
#6 Updated by Gianluca Petrillo over 4 years ago
- % Done changed from 90 to 100
#7 Updated by Gianluca Petrillo over 4 years ago
Approval tracking:
MicroBooNE | approved (20160906, Herbert Greenlee) |
DUNE | did not give a time yet |
LArIAT | approved (20160816, Brian Rebel) |
ArgoNeuT | did not give a time yet |
SBND is not in sync with LArSoft develop
, but they have already started this migration.
#8 Updated by Gianluca Petrillo over 4 years ago
Herbert Greenlee has communicated MicroBooNE's approval for this change.
#9 Updated by Gianluca Petrillo over 4 years ago
- Status changed from Resolved to Closed
Removed the "user" level of service configuration (issue #8104)