Project

General

Profile

Bug #7962

Jobsub server side logging still too verbose

Added by Parag Mhashilkar about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JobSub Server RPM
Target version:
Start date:
02/27/2015
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

Server is still logging output of following commands in the log file.

jobsub_q
jobsub_fetchlog --list

There maybe more commands but we should test it thoroughly.

It should be a easy fix since all the apis are still in place. Just need to take a pass through different actions and disable logging for some

[27/Feb/2015:09:25:18]  [format.py:_format_response] Response: {'out': ['JOBSUBJOBID                           USER          SUBMITTED     RUN_TIME   ST PRI SIZE CMD', '730768.0@fifebatch2.fnal.gov         shawest        02/25 20:51   0+18:
...
[27/Feb/2015:09:09:33]  [format.py:_format_response] Response: {'out': ['For user jbrodsky, accounting group darkside, the server can retrieve information for these job_ids:',
...

History

#1 Updated by Parag Mhashilkar about 6 years ago

  • Target version changed from v1.1.1 to v1.1.2

#2 Updated by Parag Mhashilkar about 6 years ago

We should address this sooner than later. I do not see any reason to log responses for anything except

  • job and dag submission.
  • job release/hold/rm

#3 Updated by Parag Mhashilkar about 6 years ago

  • Target version changed from v1.1.2 to v1.1.1

#4 Updated by Dennis Box about 6 years ago

  • Status changed from New to Feedback
  • Assignee changed from Dennis Box to Parag Mhashilkar

#5 Updated by Parag Mhashilkar about 6 years ago

Whats the point of following if statement in lib/JobsubConfigParser/JobsubConfigParser.py if you are only going to pass?
if not ups_ini_file:
##logger.log("using %s for jobsub config"%cnf)
pass

Rest looks ok. But make sure you test it properly to see whats written to log file.

#6 Updated by Parag Mhashilkar about 6 years ago

  • Assignee changed from Parag Mhashilkar to Dennis Box

#7 Updated by Dennis Box about 6 years ago

  • Status changed from Feedback to Resolved

merged to master

#8 Updated by Dennis Box about 6 years ago

Note on how this is tested.

Verified that v1.1.1 log is less verbose than v1.1.0 log
Verified that v1.1.1 passes regression test after changes

#9 Updated by Parag Mhashilkar almost 6 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF