Project

General

Profile

Necessary Maintenance #7572

clean up tab/space mix in jobsub_tools

Added by Dennis Box over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
12/26/2014
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

most of the python in jobsub_tools contaions a mixture of spaces and tabs, not great practice.
change them all to spaces and see if they pass the unit and integration tests

History

#1 Updated by Dennis Box over 4 years ago

  • Status changed from New to Feedback
  • Assignee changed from Dennis Box to Parag Mhashilkar

Changed all jobsub_tools python code from tabs to 8-spaces. Passes unit and integration tests after some expected tweaking.
Not sure why the push email did not show my changes. Perhaps because I branched off #7441 , trivial changes awaiting feedback.

#2 Updated by Parag Mhashilkar over 4 years ago

Indent the code to 4 spaces as a convention. Assign the ticket back to me when done.

#3 Updated by Parag Mhashilkar over 4 years ago

  • Assignee changed from Parag Mhashilkar to Dennis Box

#4 Updated by Dennis Box over 4 years ago

  • Assignee changed from Dennis Box to Parag Mhashilkar

Space indentation changed from 8 to 4. Passes unit and integration tests.

#5 Updated by Parag Mhashilkar over 4 years ago

  • Assignee changed from Parag Mhashilkar to Dennis Box

Make following changes and merge it back to master

JobSettings.py ==============

1. Bad indentation: MyCmdParser.print_help()

2. In JobSettings.__init__()
Instead of string addition use %s in following and few other places in this file

self.settings['environment']='CLUSTER=$(Cluster);PROCESS=$(Process);CONDOR_TMP='+\
self.settings['condor_tmp']+';CONDOR_EXEC='+\
self.settings['condor_exec']+';DAGMANJOBID=$(DAGManJobId
)'

#6 Updated by Dennis Box over 4 years ago

  • Status changed from Feedback to Resolved

forgot to mark resolved. when I merged

#7 Updated by Parag Mhashilkar over 4 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF