Project

General

Profile

Bug #7086

We should make all writes, particularly pickled files atomic

Added by Parag Mhashilkar over 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
09/29/2014
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

We had an instance of zero length pickle files. We want to avoid such cases in general.

History

#1 Updated by Parag Mhashilkar over 5 years ago

  • Assignee set to Parag Mhashilkar
  • Target version set to v3_2_8

#2 Updated by Parag Mhashilkar about 5 years ago

  • Target version changed from v3_2_8 to v3_2_9

#3 Updated by Parag Mhashilkar about 5 years ago

  • Assignee changed from Parag Mhashilkar to Marco Mambelli

#4 Updated by Parag Mhashilkar almost 5 years ago

  • Target version changed from v3_2_9 to v3_2_x

#5 Updated by Parag Mhashilkar over 4 years ago

  • Target version changed from v3_2_x to v3_2_13

#6 Updated by Parag Mhashilkar almost 4 years ago

  • Target version changed from v3_2_13 to v3_2_14

#7 Updated by Parag Mhashilkar over 3 years ago

  • Target version changed from v3_2_14 to v3_2_15

#8 Updated by Parag Mhashilkar over 3 years ago

  • Target version changed from v3_2_15 to v3_2_16

#9 Updated by Marco Mambelli over 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Marco Mambelli to Parag Mhashilkar

Changes are in v3/7086_2

glideFactoryEntry:
nothing there, ref to:
stats = glideFactoryLogParser.dirSummaryTimingsOut(

glideFactoryEntryGroup
- pickle to write in pipe, no file here, no changes

glideinFrontendConfig.py
class HistoryFile:
- there is no concurrency
- changed to avoid empty history file because of a crash

frontend/glideinFrontendElement.py
import cPickle but not used, rempved

frontend/glideinFrontendPlugins.py
- moved to util to improve temporary file name and use less lines

lib/condorLogParser.py
- moved loadCache/saveCache to use util to improve temporary file name and use finally

lib/fork.py
- pickle to write in pipe, only pep8 (spacing) changes

#10 Updated by Parag Mhashilkar over 3 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Parag Mhashilkar to Marco Mambelli

Looks good. Merged.

#11 Updated by Parag Mhashilkar over 3 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF