Bug #6394: Verify that association query objects are created outside tight loops
FindManyP() usage in PrimaryVertexFinder module
PrimaryVertexFinder module show non-optimal usage of associations.
I notice dubious practise in
The action I recommend:
- since you use it,
#include "art/Framework/Core/FindMany.h" and
- bring the instances
FindManyP out of the loops
const std::vector<art::Ptr<T>>& to store the result of
FindManyP::at(), that returns a constant reference, if possible
The author is Saima Farooq, roughly two years ago. I don't know if she is still maintaining this code, so I am picking
VertexFinder librarians as contact people: Jonathan Asaadi (email@example.com), Wesley Ketchum (firstname.lastname@example.org).
#1 Updated by Gianluca Petrillo almost 6 years ago
- Status changed from Assigned to Rejected
A detailed analysis of the code shows that performing the suggested change would yield complex structure.
Given that the new
FindManyP implementation has reduced complexity, the gain of this change would be questionable.