Project

General

Profile

Bug #7048

Bug #6394: Verify that association query objects are created outside tight loops

FindManyP() usage in DataScanner module

Added by Gianluca Petrillo over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Reconstruction
Target version:
-
Start date:
09/22/2014
Due date:
% Done:

0%

Estimated time:
1.00 h
Occurs In:
Experiment:
MicroBooNE
Co-Assignees:
Duration:

Description

DataScanner module shows non-optimal use of associations:

uboonecode/uboone/DataScanner/DataScanner_module.cc

The action I recommend:
- bring the queries FindManyP() out of the loops
- use const std::vector<art::Ptr<T> >& to store the result of FindManyP::at(), that returns a constant reference

Contact person is Kazuhiro Terao ()

History

#1 Updated by Gianluca Petrillo over 6 years ago

  • Status changed from New to Assigned

#2 Updated by Gianluca Petrillo over 5 years ago

  • Status changed from Assigned to Closed

Closed after its parent issue.

Also available in: Atom PDF