Project

General

Profile

Feature #6803

EmptyEvent_source.cc Doesn't support second time. Only nanosec time.

Added by Nathan Mayer about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Immediate
Assignee:
Christopher Green
Category:
Event Loop
Target version:
1.11.00
Start date:
08/14/2014
Due date:
% Done:

100%

Estimated time:
2.00 h
Spent time:
24.00 h
Scope:
Internal
Experiment:
NOvA
SSI Package:
art
Duration:

Description

The EmptyEvent_source module doesn't support second time. It only supports nanosecond time. Further more, as near as I can tell. When the ns roll over into seconds. The seconds term doesn't increment. I've written a fix, to the module that should be able to be imported directly into art as is. I'd be happy to show it to someone.

Associated revisions

Revision aacd7992 (diff)
Added by Christopher Green about 6 years ago

Issue #6803.

Operation verified manually. Automated tests to follow.

History

#1 Updated by Gavin Davies about 6 years ago

It's probably useful to add a link to what Nate has done for NOvA.
He took a copy of the EmptyEvent_source.cc module and edited it within the NOvA code here:

https://cdcvs.fnal.gov/redmine/projects/novaart/repository/changes/trunk/EventGenerator/NovaMCEmptyEvent_source.cc

He added support for time in seconds when the nanoseconds roll over into a second, but only into the first second. Thus all of our simulated events will have a timestamp occuring within a second.

Essentially we are trying to match what our Data timestamps look like and would like to be able roll forward into the seconds term for the timestamp. Does adding this support break any fundamental thinking for Simulation Event generation?
Given that the support is there and provided for building the art::Event from our data we;d be surprised if it wasn't possible but please advise. Maybe there is something obvious we are missing - I'm not claiming to be the expert on this either I'm just adding some extra information to Nate's ticket to help expedite feedback.

#2 Updated by Christopher Green about 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Christopher Green
  • Priority changed from Normal to Immediate
  • Target version set to 1.11.00
  • Estimated time set to 2.00 h
  • SSI Package art added
  • SSI Package deleted ()

#3 Updated by Christopher Green about 6 years ago

  • Category changed from User Code to Event Loop
  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Solution implemented with tests with 25528730d2ccc0b887b5d4d462d0ba7f65e58753.

The user is expected to write their own plugin inheriting from source:art/Framework/Core/EmptyEventTimestampPlugin.h. The resulting .so library should have a name ending in _plugin.so. Documentation to follow, see upcoming release notes.

#4 Updated by Christopher Green about 6 years ago

  • Status changed from Resolved to Closed

#5 Updated by Gavin Davies about 6 years ago

Correction

Christopher Green wrote:

Solution implemented with tests with 25528730d2ccc0b887b5d4d462d0ba7f65e58753.

The user is expected to write their own plugin inheriting from source:art/Framework/Core/EmptyEventTimestampPlugin.h. The resulting .so library should have a name ending in _plugin.so. Documentation to follow, see upcoming release notes.

#6 Updated by Christopher Green about 6 years ago

Gavin, I'm not sure what you were intending to say with this last update. Could you clarify, please?

#7 Updated by Gavin Davies about 6 years ago

Oh the link to the source file in your previous comment had a typo. Empry vs. Empty.
I just reposted with the correction.

#8 Updated by Christopher Green about 6 years ago

Ah, fixed in-place. I looked at it multiple times and didn't see the problem.

Thanks,
Chris.

Also available in: Atom PDF