Project

General

Profile

Bug #6671

CondorMonitor improperly handles security changes in case of exeptions

Added by Igor Sfiligoi over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Igor Sfiligoi
Category:
-
Target version:
Start date:
07/24/2014
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

I just found out that the CondorStatus class does not properly clean up ins internal security changes in case of an exception.
Other classes in the CondorMonitor library likely have the same problem.


Related issues

Blocks GlideinWMS - Bug #6669: glidein_off does not work with HA collectorClosed07/24/2014

History

#1 Updated by Igor Sfiligoi over 5 years ago

Noticed this as a side effect of the glidein_off bug;
on retry, CondorStatus will complain like so:

Traceback (most recent call last):
  File "glidein_off", line 301, in <module>
    sys.exit(main(sys.argv))
  File "glidein_off", line 240, in main
    addrs,failures = lookup_addrs(complete_constr)
  File "./glidein_off", line 154, in lookup_addrs
    data = sts.fetch(master_constr,[('MyAddress','s')])
  File "lib/condorMonitor.py", line 342, in fetch
    return QueryExe.fetch(self, constraint=constraint, format_list=format_list)
  File "lib/condorMonitor.py", line 266, in fetch
    self.security_obj.save_state()
  File "lib/condorSecurity.py", line 131, in save_state
    raise RuntimeError,"There is already a saved state! Restore that first." 
RuntimeError: There is already a saved state! Restore that first.

#2 Updated by Igor Sfiligoi over 5 years ago

  • Status changed from New to Feedback
  • Assignee changed from Igor Sfiligoi to Parag Mhashilkar

Fixed in v3/6671.

Please review.

#3 Updated by Parag Mhashilkar over 5 years ago

Looks ok. Merged it to branch_v3_2 and master

#4 Updated by Parag Mhashilkar over 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Parag Mhashilkar to Igor Sfiligoi

#5 Updated by Parag Mhashilkar over 5 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF