Project

General

Profile

Bug #6490

Ensure range for support for art suite containers (map_vector, PtrVector, FindOne, FindMany)

Added by Christopher Green over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Navigation
Target version:
Start date:
06/17/2014
Due date:
% Done:

100%

Estimated time:
16.00 h
Spent time:
Occurs In:
Scope:
Internal
Experiment:
-
SSI Package:
art
Duration:

Description

For use with range for.

History

#1 Updated by Christopher Green about 6 years ago

  • Subject changed from Provide begin() and cbegin() for cetlib and art continers (map_vector, PtrVector, FindOne, FindMany) to Ensure range for support for art suite containers (map_vector, PtrVector, FindOne, FindMany)
  • Category set to Navigation
  • Status changed from New to Accepted
  • Estimated time set to 16.00 h
  • SSI Package art added
  • SSI Package deleted ()
  • map_vector is missing cXXX functions.
  • PtrVector has all expected functions, but it is unclear whether range for behavior is tested.
  • FindOne and FindMany do not expose the underlying iterators currently, and neither do they provide operator[]. We would need to consult with expert users on the correct value_type for FindXXXX<ProdB, Data>: should the iterator have a data() function; should the value_type be (e.g.) std::pair<ProdB, Data> or should we continue to require the user to obtain the associated data item directly from the container?

#2 Updated by Christopher Green about 6 years ago

  • Target version set to 1.13.00

#3 Updated by Christopher Green over 5 years ago

  • Target version changed from 1.13.00 to 1.14.00

#4 Updated by Kyle Knoepfel over 5 years ago

  • Status changed from Accepted to Assigned
  • Assignee set to Kyle Knoepfel

#5 Updated by Kyle Knoepfel over 5 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

After discussion, we have concluded that enabling range-for support for FindOne and FindMany is not well-motivated and will not be implemented. We have added range-for support, however, for cet::map_vector and art::PtrVector.

Implemented with commits cetlib:487bf0260c0345022340595fdaa0f2fd77b18889 and art:1db11a22bb6dc320b456557fbef58e630cb7883c.

#6 Updated by Kyle Knoepfel over 5 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF