Bug #6394
Verify that association query objects are created outside tight loops
100%
Description
Query objects (e.g. FindMany) do a lot of work on creation.
They should be created outside tight loops and with as input all the objects we want the associations of.
Subtasks
History
#1 Updated by Gianluca Petrillo almost 7 years ago
- Assignee set to Gianluca Petrillo
#2 Updated by Lynn Garren almost 7 years ago
- Status changed from New to Assigned
#3 Updated by Gianluca Petrillo over 6 years ago
- Category set to Other
- % Done changed from 0 to 10
- Estimated time set to 80.00 h
The following classes contain FindMany/FindManyP objects inside loops:
larreco
ClusterPCALineMergerShowerAngleClusterEventMakerShowerCheaterShowerFinderShowerRecoTrackAnaCosmicTrackerTrack3DKalmanTrack3DrecoTrackAnaTrackCheaterTrackStitcherAggregateVertexPrimaryVertexFinderVertexCheater
larana
Calorimetry
lareventdisplay
AnalysisBaseDrawerRecoBaseDrawer
uboonecode
AnalysisTreeDataScanner
I will address a very few of them personally.
The authors will be contacted to fix the code.
#4 Updated by Gianluca Petrillo over 6 years ago
- Experiment LArSoft added
- Experiment deleted (
-)
At a second look, AnalysisBaseDrawer is actually fine.
Single issues have been opened and assigned to the authors, to better track the different components.
#5 Updated by Gianluca Petrillo over 5 years ago
- Status changed from Assigned to Closed
Closing for lack of activity.
I consider the degree of solution we reached to be satisfactory.
No place with relevant issues persists. The remaining few instances would not be a problem as they are not in tight loops.
Furthermore, upstream optimization of the query objects would dramatically mitigate such problems if they existed.