Project

General

Profile

Bug #6336

Review and remove obsolete code

Added by Ben Morgan over 5 years ago. Updated almost 2 years ago.

Status:
Accepted
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
09/16/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Spent time:
(Total: 0.25 h)
Duration:

Description

Several areas of messagefacility appear to be no longer used, or to use obsolete APIs of fhicl-cpp.

  • messagefacility/MessageLogger/LoggedErrorsSummary.h: Has incorrect header guards
  • messagefacility/MessageService/ELtsErrorLog.icc: void ELtsItem tries to access private/protected data
  • messagefacility/MessageService/MessageLoggerScribe.h: Extensive use of old APIs of fhiclcpp::ParameterSet, e.g. getParameter

Most problems are in template code so are never compiled directly, but nevertheless are still potentially available.


Subtasks

Bug #7018: Apply patches to allow clang compilation of obsolete code.ClosedChristopher Green

History

#1 Updated by Christopher Green over 5 years ago

  • Status changed from New to Accepted

We stipulate that there is a large amount of obsolete code in messagefacility: the list of such code was made last year. We are waiting for priority and effort assignment in order to do the full clean-up. We will bring this up again within our department to see if we can get effort assigned.

#3 Updated by Kyle Knoepfel over 4 years ago

  • Target version set to 521

#4 Updated by Kyle Knoepfel almost 2 years ago

  • Target version deleted (521)


Also available in: Atom PDF