Bug #6336
Review and remove obsolete code
Description
Several areas of messagefacility appear to be no longer used, or to use obsolete APIs of fhicl-cpp.
messagefacility/MessageLogger/LoggedErrorsSummary.h: Has incorrect header guardsmessagefacility/MessageService/ELtsErrorLog.icc:void ELtsItemtries to access private/protected datamessagefacility/MessageService/MessageLoggerScribe.h: Extensive use of old APIs offhiclcpp::ParameterSet, e.g.getParameter
Most problems are in template code so are never compiled directly, but nevertheless are still potentially available.
Subtasks
History
#1 Updated by Christopher Green almost 6 years ago
- Status changed from New to Accepted
We stipulate that there is a large amount of obsolete code in messagefacility: the list of such code was made last year. We are waiting for priority and effort assignment in order to do the full clean-up. We will bring this up again within our department to see if we can get effort assigned.
#2 Updated by Ben Morgan over 5 years ago
- File 0001-messagefacility-Remove-ELtsItem-template-function.patch 0001-messagefacility-Remove-ELtsItem-template-function.patch added
- File 0002-messagefacility-Use-updated-fhiclcpp-interfaces.patch 0002-messagefacility-Use-updated-fhiclcpp-interfaces.patch added
- File 0003-messagefacility-Add-needed-sys-time.h-header.patch 0003-messagefacility-Add-needed-sys-time.h-header.patch added
- File 0004-messagefacility-Use-consistent-ifdef-define-name.patch 0004-messagefacility-Use-consistent-ifdef-define-name.patch added
In getting things working on Mac+Clang, I've created patches for the above reported issues. I've attached these as individual patches for each issue as they are atomic, but I can squash if you prefer. They can also be reviewed on GitHub
#3 Updated by Kyle Knoepfel almost 5 years ago
- Target version set to 521
#4 Updated by Kyle Knoepfel over 2 years ago
- Target version deleted (
521)