Project

General

Profile

Bug #5595

create_frontend not populating the images on the monitoring page

Added by Igor Sfiligoi almost 6 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Frontend Monitoring
Target version:
Start date:
03/05/2014
Due date:
% Done:

100%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

The main frontend monitoring (index) page is broken.

It is referencing pictures in the images subdirectory, that does not exist.

My guess is that the create_frontend is not doing its job.

History

#2 Updated by Parag Mhashilkar about 5 years ago

  • Target version changed from v3_2_x to v3_2_9

#3 Updated by Parag Mhashilkar almost 5 years ago

  • Target version changed from v3_2_9 to v3_2_x

#4 Updated by Parag Mhashilkar almost 5 years ago

  • Assignee changed from Marco Mambelli to HyunWoo Kim

#5 Updated by Parag Mhashilkar over 4 years ago

  • Target version changed from v3_2_x to v3_2_12

#6 Updated by HyunWoo Kim over 4 years ago

  • % Done changed from 0 to 90

I identified the code of Frontend which shows how we make sure that the images are populated.
This only applies when we install GWMS manually.
RPM version includes the images in it.
I will just have to confirm my finding by manually installing Frontend and running create_frontend script.
It is also recommended by Parag that we should modify the code such that these images are installed always.

#7 Updated by HyunWoo Kim over 4 years ago

  • Status changed from New to Feedback
  • Assignee changed from HyunWoo Kim to Parag Mhashilkar

I created a new branch v3/5595 off branch_v3_2
and modified one file creation/lib/cvWParamDict.py to comment out just 2 lines:

Please review this one file.

#8 Updated by Parag Mhashilkar about 4 years ago

  • Assignee changed from Parag Mhashilkar to HyunWoo Kim

I am assuming you tested this to work with both rpm and tarball.

Code can be cleaned up further

  • variable spd is not required - Remove
  • commented code - Remove
  • useMonitorIndexPage is not required if are unconditionally setting it to True - Remove
  • Code inside "if usMonitorIndexPage:" will always be executed so just remove the if statement - shift the code indentation to get desired results
        spd = self.params.data
        useMonitorIndexPage = True
#        if spd.has_key('frontend_monitor_index_page'):
#            useMonitorIndexPage = spd['frontend_monitor_index_page'] in ('True', 'true', '1')

        if useMonitorIndexPage:
            mfobj = cWDictFile.SimpleFile(params.src_dir + '/frontend', 'index.html')
            mfobj.load()
            self.monitor_htmls.append(mfobj)

            for imgfil in ('frontendGroupGraphsNow.small.png',
                           'frontendRRDBrowse.small.png',
                           'frontendRRDGroupMatix.small.png',
                           'frontendStatus.small.png'):
                mfobj = cWDictFile.SimpleFile(params.src_dir + '/frontend/images', imgfil)
                mfobj.load()
                self.monitor_htmls.append(mfobj)

#9 Updated by HyunWoo Kim about 4 years ago

I have modified the code cvWParamDict.py per the review.
I will just have to test-install the tar-ball version and see if the images are populated
And I will close this ticket

#10 Updated by HyunWoo Kim about 4 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

I confirmed that this change now enables the tar-ball install to populate /var/www/html/frontend/master/monitor/frontend_Frontend-master-v1_0/ with the images.
I am closing this ticket.

#11 Updated by Parag Mhashilkar about 4 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF