Project

General

Profile

Bug #5362

LArPandora module does not follow the approved 1 file per module format

Added by Brian Rebel over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
02/06/2014
Due date:
% Done:

100%

Estimated time:
Occurs In:
Experiment:
-
Co-Assignees:
Duration:

Description

Modules should have only a *_module.cc file, no associated .h and .cxx files. LArPandora_module.cc currently does not conform to this format.

The ART developers say using the 3 file format "gives unnecessary complexity, increases dependencies (multiple modules will depend on a given library, the only thing in common between them being that their unrelated guts are all in the same library) and increases the likelihood of unintentional and/or ill-advised use of module methods / data from outside said modules, thereby breaking the event model and event data integrity."

The files should be merged and hopefully preserve the history information if at all possible.

Associated revisions

Revision d7ee45b9 (diff)
Added by Gianluca Petrillo over 6 years ago

Merged source code of LArPandora module in one single file (larsoft issue #5362)

History

#1 Updated by Erica Snider over 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Gianluca Petrillo

#2 Updated by Gianluca Petrillo over 6 years ago

  • Status changed from Assigned to Resolved
  • Target version set to v1_00_04

The code has been concentrated in the only larpandora/LArPandoraInterface/LArPandora_module.cc.

#3 Updated by Gianluca Petrillo over 6 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100


Also available in: Atom PDF