Project

General

Profile

Bug #5111

BeamDataUtil/BDSpillAccessor assumes DBI rows come back from DB time ordered

Added by Robert Hatcher almost 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Start date:
12/18/2013
Due date:
% Done:

0%

Estimated time:
Duration:

Description

The code in BDSpillAccessor::TableSearch() appears to implicitly assume that rows in the DbiResultPtr<BeamMonSpill> &table are ordered by ROW_COUNTER (which itself is time ordered) when deciding "before" and "after" BeamMonSpill entries. But the DBI explicitly states that one can not assume that (see User Manual http://www-numi.fnal.gov/offline_software/srt_public_context/doc/UserManual/node9.html#SECTION00922500000000000000 ) unless one has <predbiCfg.Set("OrderContextQuery = 1");.

No where in the MINOS code is this enabled. Doing so would force all queries of all tables to be sorted (which would solve such implicit assumptions, but needs to be studied to ensure that it doesn't impact DB performance/load significantly).



Also available in: Atom PDF