Project

General

Profile

Support #5036

Change usage of DetId_t enum defined in SimpleTypesAndConstants to accept arbitrary strings.

Added by Erica Snider almost 7 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
08/12/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Experiment:
-
Co-Assignees:
Duration:

Description

Currently some classes understand the mapping between this enum and detector name strings. Will change this to use only strings throughout


Subtasks

Bug #6786: larcore: Geometry/Geometry_service.ccClosedBrian Rebel

History

#1 Updated by Erica Snider almost 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Erica Snider

#2 Updated by Erica Snider about 6 years ago

  • Assignee changed from Erica Snider to Brian Rebel

Re-assigning to go along with the associated ticket opened by Corey.

#3 Updated by Gianluca Petrillo about 6 years ago

  • Target version changed from v1_01_00 to v02_06_00

#4 Updated by Brian Rebel over 5 years ago

Issue partially resolved with commit

https://cdcvs.fnal.gov/redmine/projects/larcore/repository/revisions/3a9b3360593d9942deb8461a13709e008014926a

to the LArCore repository. Enumerations are still allowed for backwards compatibility with old files. A decision needs to be made as to when the enumerations can be removed completely.

#5 Updated by Ruth Pordes almost 5 years ago

Introduced the changes needed to do this.

needs making sure to remove the use of enums and then close.

#6 Updated by Brian Rebel almost 5 years ago

  • Status changed from Assigned to Resolved

The use of DetId_t types has been removed from LArSoft. There should be no impact to code as the default was to use the string values instead for the last year. The LArSoft list was emailed on November 12, 2015 to ask if there would be any objections to removing this type from files, no objections were communicated by COB November 13, 2015 as specified in the email.

#7 Updated by Brian Rebel almost 5 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF