Project

General

Profile

Bug #4844

Feature #2811: OSG: Create plug-in architecture for frontends

xslt plugin changes break the factory (maybe also frontend) reconfig after the service is upgraded

Added by Parag Mhashilkar about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Parag Mhashilkar
Category:
-
Target version:
Start date:
10/24/2013
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

xslt plugin creation code creates a temporary xml file to work with after applying xslt transformations. There are couple of issues with the way it works with factory_startup and frontend_startup scripts.

Reconfig

  • The logging is confusing and shows the temporary config filename (/tmp/tmp_mivls). See below -
[factory@fermicloud030 glidein_v1_0]$ ./factory_startup reconfig
Using default factory config file: /local/home/factory/master/glideinsubmit/glidein_v1_0.cfg/glideinWMS.xml
Shutting down glideinWMS factory v1_0@GlideinFactory-master[OK]
...Saved the current config file into the working dir
...Saved the backup config file into the working dir
...Reconfigured glidein 'v1_0' is complete
...Active entries are:
[...]
...Verifying rrd schema
...Submit files are in /local/home/factory/master/glideinsubmit/glidein_v1_0
...Overriding the factory config file in /tmp/tmp_mivls to the current configuration 
Reconfiguring the factory                                  [OK]
Starting glideinWMS factory v1_0@GlideinFactory-master:    [OK]

Upgrade

It becomes interesting when you upgrade. You can also reproduce this with "factory_startup upgrade <filename>"

  • After running factory_upgrade, it creates a new factory_startup script with the default_cfg_fpath set to this temporary file.
    # After above reconfig
    [factory@fermicloud030 glidein_v1_0]$ ./factory_startup upgrade
    Using default factory config file: /local/home/factory/master/glideinsubmit/glidein_v1_0.cfg/glideinWMS.xml
    Shutting down glideinWMS factory v1_0@GlideinFactory-master[OK]
    ...Updated the glidein_startup.sh and local_start.sh scripts
    ...Updated the glidein_startup.sh file in the staging area
    ...Updated the factory_startup script
    ...Saved the current config file into the working dir
    ...Saved the backup config file into the working dir
    ...Reconfigured glidein 'v1_0' is complete
    ...Active entries are:
    [...]
    ...Verifying rrd schema
    ...Submit files are in /local/home/factory/master/glideinsubmit/glidein_v1_0
    ...Overriding the factory config file in /tmp/tmpB5txkL to the current configuration 
    Upgrading the factory                                      [OK]
    Starting glideinWMS factory v1_0@GlideinFactory-master:    [OK]
    
  • Now your default_cfg_path has permanently changed to a file thats been log gone and deleted.
[factory@fermicloud030 glidein_v1_0]$ grep "^default_cfg_fpath" factory_startup 
default_cfg_fpath=/tmp/tmpB5txkL
  • Now you cannot ever reconfig with this startup script!

History

#1 Updated by Burt Holzman about 7 years ago

This affects non-RPM installs.

If you are using the RPM and always use the initscripts (i.e. /sbin/service gwms-frontend upgrade), it's ok. I'm not saying this doesn't need to be fixed for 3.2.1, but the scope is a little more limited.

#2 Updated by Burt Holzman about 7 years ago

  • Status changed from New to Closed

Parag and I reviewed the changes, it's been merged into v3.2.1rc2.

Also available in: Atom PDF