Project

General

Profile

Support #4465

Efficiency/sloppiness audit

Added by Michael Baird about 7 years ago.

Status:
New
Priority:
Normal
Assignee:
Michael Baird
Start date:
07/31/2013
Due date:
% Done:

0%

Estimated time:
Duration:

Description

I probably shouldn't lump these together into one issue, but we need an efficiency/sloppiness audit of much of the OnMon code. Some examples of things that are being done poorly are:

1. RawEventSummary keeps a list of which DCMs have reported in the event but this list is not being used by the EmptyDCM plots. This list is being regenerated because the way the RawEventSummary list is being kept is a bit weird.
2. There are a whole bunch of special plot options in PlotOptions.h that are stored as individual boolians. So if you want to add a new special drawing option for a plot, you have to add another variable to PlotOptions. Perhaps we could make one list of special plot options (like a 32 bit integer) and we just set the right bits depending on which plot option is desired. This might make it easier to add new plot drawing options in the future...?
3. The histogram maker titled "FEBRatesByDB" makes more than just the FER rate plots. Maybe it should be re named?

Also available in: Atom PDF