Project

General

Profile

Bug #4458

art::shutdown_flag should be atomic

Added by Christopher Green about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Infrastructure
Target version:
Start date:
10/10/2013
Due date:
10/10/2013
% Done:

100%

Estimated time:
1.00 h
Spent time:
Occurs In:
Scope:
Internal
Experiment:
-
SSI Package:
art
Duration: 1

Description

art::shutdown_flag is currently volatile int. This is not thread-safe against read/write order if it is likely that this value might be accessed from different threads. It should be std::atomic<int> instead.


Related issues

Related to art - Necessary Maintenance #4459: Signal handling should be reviewed to ensure that signals are always handled by the correct thread.Accepted09/30/2013

Related to art - Feature #4356: Document the pattern that artdaq applications should use to correctly handle signals [ds50daq-related]Closed07/17/201307/31/2013

Related to art - Feature #4355: Document and verify the signal handling within art [ds50daq-related]Closed07/17/201307/31/2013

Associated revisions

History

#1 Updated by Christopher Green about 7 years ago

  • Status changed from New to Accepted

#2 Updated by Christopher Green almost 7 years ago

  • Due date changed from 09/30/2013 to 10/10/2013
  • Assignee set to Christopher Green
  • Start date set to 10/10/2013
  • % Done changed from 0 to 100

Implemented with commit:77c434f.

#3 Updated by Christopher Green almost 7 years ago

  • Status changed from Accepted to Resolved

#4 Updated by Christopher Green over 6 years ago

  • Target version changed from 1.09.00 to 1.08.09

#5 Updated by Lynn Garren over 6 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF