Necessary Maintenance #4367: OutputModule problems. - art - Fermilab Redmine

Necessary Maintenance #4367

Feature #8593: Improve flexibility of output file handling

OutputModule problems.

Added by Christopher Green almost 7 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

I/O

Target version:

2.01.00

Start date:

07/18/2013

Due date:

09/30/2013

% Done:

100%

Estimated time:

4.00 h

Scope:

Experiment:

SSI Package:

art

Duration: 75

Description

The inconsistent use and misuse of template method dispatch in this base class is almost guaranteed to lead to confusion, problems and misbehavior. There is also a confusing overload set (doOpenFile()) with one virtual function never actually called.

Associated revisions

Revision b98b500f (diff)
Added by Christopher Green almost 7 years ago

Confusion avoidance per issue #4367.

Function definitions removed from class definition for OutputModule.

Vestigial and confusing virtual / non-virtual overload set for doOpenFile(...) rationalized.

History

#1 Updated by Christopher Green almost 7 years ago

Subject changed from ODR violation in OutputModule (among oher serious problems). to OutputModule problems.
Description updated (diff)
Priority changed from Urgent to Normal
Scope set to Internal

#2 Updated by Christopher Green almost 7 years ago

% Done changed from 0 to 70

Confusion partially resolved with b98b500fee171f787d74177e139149404f77e55e. Fixing the template method dispatch inconsistency may be usefully postponed to a later date.

#3 Updated by Christopher Green almost 7 years ago

Tracker changed from Bug to Necessary Maintenance
Due date set to 09/30/2013
Target version set to 1.09.00
Estimated time set to 4.00 h

The time estimate reflects the time needed to evaluate whether anything else can be done to improve the code (esp. with respect to template dispatch method) without causing downstream disruption to third party output modules.