Necessary Maintenance #4367
Feature #8593: Improve flexibility of output file handling
OutputModule problems.
100%
Description
The inconsistent use and misuse of template method dispatch in this base class is almost guaranteed to lead to confusion, problems and misbehavior. There is also a confusing overload set (doOpenFile()) with one virtual function never actually called.
Associated revisions
History
#1 Updated by Christopher Green about 6 years ago
- Subject changed from ODR violation in OutputModule (among oher serious problems). to OutputModule problems.
- Description updated (diff)
- Priority changed from Urgent to Normal
- Scope set to Internal
#2 Updated by Christopher Green about 6 years ago
- % Done changed from 0 to 70
Confusion partially resolved with b98b500fee171f787d74177e139149404f77e55e. Fixing the template method dispatch inconsistency may be usefully postponed to a later date.
#3 Updated by Christopher Green about 6 years ago
- Tracker changed from Bug to Necessary Maintenance
- Due date set to 09/30/2013
- Target version set to 1.09.00
- Estimated time set to 4.00 h
The time estimate reflects the time needed to evaluate whether anything else can be done to improve the code (esp. with respect to template dispatch method) without causing downstream disruption to third party output modules.
#4 Updated by Christopher Green over 5 years ago
- Target version changed from 1.09.00 to 521
#5 Updated by Marc Paterno over 4 years ago
- Parent task set to #8593
#6 Updated by Christopher Green over 4 years ago
- Target version changed from 521 to 1.18.00
#7 Updated by Christopher Green almost 4 years ago
- Target version changed from 1.18.00 to 834
#8 Updated by Marc Paterno almost 4 years ago
- Target version changed from 834 to 3.12.06
#9 Updated by Christopher Green almost 4 years ago
- Target version changed from 3.12.06 to 521
#10 Updated by Kyle Knoepfel over 3 years ago
- Status changed from Accepted to Resolved
- Target version changed from 521 to 2.01.00
- % Done changed from 70 to 100
- SSI Package art added
The recent improvements are sufficient to mark this issue as resolved.
#11 Updated by Kyle Knoepfel over 3 years ago
- Status changed from Resolved to Closed
Confusion avoidance per issue #4367.
Function definitions removed from class definition for OutputModule.
Vestigial and confusing virtual / non-virtual overload set for doOpenFile(...) rationalized.