Project

General

Profile

Bug #4276

MASTER: Improve factory performance in writeStats to bring down the loop time to acceptable value

Added by Parag Mhashilkar over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Parag Mhashilkar
Category:
-
Target version:
Start date:
07/01/2013
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

  • Merge changes made for #4229 to Master
  • Consolidate Classad Class which is now duplicated in factory and frontend

Related issues

Related to GlideinWMS - Bug #3211: Group multiple condor_advertise for entries in an entry groupClosed12/27/2012

Related to GlideinWMS - Bug #4229: Improve factory performance in writeStats to bring down the loop time to acceptable value.Closed06/27/2013

History

#1 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from New to Assigned
  • Target version changed from v3_x to 382

I have made relevant changes into master_4276 locally. Once we release v3.1, I will test the changes and push it to remote repo

#2 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from Parag Mhashilkar to Burt Holzman

All the changes are now tested and pushed to remote. This is now available for review.

#3 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from 382 to v3_2

#4 Updated by Burt Holzman over 7 years ago

Two bugs: the signal handling around the child (which I fixed), and log.warn should be log.warning I believe.

I have lots of minor nits -- the logic could be simpler with need_cleanup/last_cleanup, use of iteritems(), removing duplicated code
in advertizeGlideinClientMonitoringFromFile and advertizeGlideinFromFile, but that shouldn't stop this from going forward.

#5 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Feedback to Closed
  • Assignee changed from Burt Holzman to Parag Mhashilkar

Burt also pointed out about the redundant call to cleanup. Fixed the cleanup and fixed the call to log.warning. Merged into master. Closing this ticket.

Also available in: Atom PDF