Project

General

Profile

Feature #4192

use tabnanny or other system to check all python scripts before launching pipeline

Added by Brian Nord over 7 years ago. Updated over 7 years ago.

Status:
Rejected
Priority:
Normal
Category:
SVN and Software
Target version:
Start date:
06/22/2013
Due date:
% Done:

0%

Estimated time:
Duration:

Description

May we add a quality assurance check on all python modules before the pipeline runs that checks for correct tabbing?

Currently, when I edit a script, I use 'python -m tabnanny' before committing.

History

#1 Updated by Laurenz Gamper over 7 years ago

  • Status changed from Assigned to Rejected

In 98% of the times I run the script before I commit to make sure it's working. I think quality assurance should be that the pipeline runs in one or a few configurations with somehow reasonable results. Correct tabbing (and correct syntax) is in my opinion a basic requirement for each programmer that commits to a pipeline like spokes.
When we check, then for the code working correctly (tests succeeding) but I don't think we should support and encourage bad programming practices and and bad editors or bad editor configurations (a editor should do the tabbing right automatically).



Also available in: Atom PDF