Project

General

Profile

Bug #3454

Bug #2729: Potential error in set_var

set_var still fails under certain condtions

Added by Parag Mhashilkar almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Parag Mhashilkar
Category:
Factory
Target version:
Start date:
02/10/2013
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

The field count check introduced in the #2729 is bugged and fails when value of the field is 0.

echo " d    0       " | awk '{if ($2) print "second field present"; else print "second field absent"}'
second field absent

Correct way is to count the field count

echo " d    0       " | awk '{if (NF>1) print "second field present"; else print "second field absent"}'
second field present

History

#1 Updated by Parag Mhashilkar almost 8 years ago

  • Assignee changed from Parag Mhashilkar to Douglas Strain

Fixed in branch_v2plus_3454

#2 Updated by Parag Mhashilkar almost 8 years ago

  • Status changed from Assigned to Feedback

#3 Updated by Burt Holzman almost 8 years ago

Good eye.
Doesn't this affect only master? I don'tt hink 2729 was merged into branch_v2plus, was it?

#4 Updated by Parag Mhashilkar almost 8 years ago

It was merged in branch_v2plus.

[parag@cd-109337 glideinwms]$ git show 2f45d3c7101df6dbe98b49c05ffa6a33e4ddd1d6
commit 2f45d3c7101df6dbe98b49c05ffa6a33e4ddd1d6
Merge: dcdcf55 5059fca
Author: Burt Holzman <burt@fnal.gov>
Date:   Tue Jan 8 14:04:18 2013 -0600

    Merge branch 'branch_v2plus_2729' into branch_v2plus

#5 Updated by Parag Mhashilkar almost 8 years ago

I already merged this into branch_v2plus and master. Will revert the change if required based on the feedback.

#6 Updated by Douglas Strain almost 8 years ago

  • Status changed from Feedback to Resolved

This change looks fine to me.

#7 Updated by Douglas Strain almost 8 years ago

  • Assignee changed from Douglas Strain to Parag Mhashilkar

#8 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF