cet-is » art

Dear ART Team,

I used artmod to create the skeleton for a generator and it did not compile right out of the box, so I just wanted to let you know what I changed. Please let me know if any of my changes are not the ideal thing to do.

Here is how I created the generator:

artmod generator novaddt::NovaFragmentFileReader

and here are the issues I ran into:

1. artdaq/DAQdata/FragmentGenerator.h needs an extra "h" to make it artdaq/DAQdata/FragmentGenerator.hh.

2. FragmentPtrs needed the artdaq namespace to make it artdaq::FragmentPtrs.

3. I needed to add noexcept (true) to the destructor to make it as strict as the method it inherits from.

4. Chris already fixed this, but for completeness' sake, the following header had to be changed from #include "art/Framework/Core/ModuleMacros.h" to #include "artdaq/DAQdata/GeneratorMacros.hh".

Thank you for maintaining this artmod function, it makes our lives much easier!

Regards,
Martin