Project

General

Profile

Bug #3167

FactoryMatchAttrs never used

Added by Burt Holzman over 6 years ago. Updated about 6 years ago.

Status:
Assigned
Priority:
Normal
Assignee:
Parag Mhashilkar
Category:
Factory
Target version:
Start date:
12/11/2012
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

This is from an old e-mail:

" 
Hi guys.
I just noticed that we never use
FactoryMatchAttrs
in the code!!!!
While we do use JobMatchAttrs in condor_q,
we never implemented the equivalent for the condor_status toward the factory.
I cannot think of a good reason why we are doing it this way; seems like a bug to me.
The net result is that we are loading much more than needed the factory collector, wasting network bandwidth and frontend resources (both memory and cpu).
Thoughts?
Igor
PS: This is definitely not a showstopper for v2.5.2, since it has been working like this for a while.
"
" 
BTW: I ran a test comparing run times with and without filtering.
For CMS, the matching phase takes about 15% longer without FactoryMatchAttrs filtering.
(77s vs 66s)
Igor
"

I did this a long time ago, but we never merged it. Making it a proper bug and putting it in a renamed branch for review.

History

#1 Updated by Burt Holzman over 6 years ago

  • Status changed from Feedback to Resolved

Parag gave this the OK. Mergedto branch_v2plus and cherry-picked to master.

#2 Updated by Burt Holzman over 6 years ago

  • Status changed from Resolved to Assigned
  • Target version changed from 293 to v2_7_x

Ok, I misread the intent here.
The idea is not to remove the unused FactoryMatchAttrs, but to implement it and use it for filtering.
Re-opening this ticket for 2.6.x.

- B

#3 Updated by Parag Mhashilkar about 6 years ago

  • Target version changed from v2_7_x to v3_x


Also available in: Atom PDF