Project

General

Profile

Bug #3157

Correct the way we use subprocess

Added by Parag Mhashilkar almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Parag Mhashilkar
Category:
Factory
Target version:
Start date:
12/03/2012
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

1) Change open file limit to 1024 for entry processes. Entry processes don't need more file descriptors
2) Entries should not inherit FDs from master factory process: subprocess.Popen() defaults to close_fds=True

Burt has already implemented the changes in factory-scaling branch. Review and merge it to v2.6.3

History

#1 Updated by Burt Holzman almost 8 years ago

Just a note -- the side-effect is that for large open file limits, the factory will take longer to start up than 2.6.3rc1 (but no longer than in 2.6.2).

#2 Updated by Parag Mhashilkar almost 8 years ago

  • Assignee changed from Parag Mhashilkar to Douglas Strain

#3 Updated by Douglas Strain almost 8 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from Douglas Strain to Parag Mhashilkar

I have tested this, and it seems to be working fine. I'll assign it back to Parag to see if he has any additional comments before merging.

#4 Updated by Parag Mhashilkar almost 8 years ago

  • Status changed from Feedback to Resolved

Merged it into branch_v2plus

#5 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from 293 to v2_7

#6 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF