Project

General

Profile

Feature #3128

Migrate installers to use subprocess, not popen

Added by Burt Holzman about 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Low
Assignee:
John Weigand
Category:
-
Target version:
Start date:
11/16/2012
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

In #2634 we migrate the main codebase from popen to subprocess. The installers should follow suit.

History

#1 Updated by Burt Holzman about 8 years ago

  • Tracker changed from Bug to Feature

#2 Updated by John Weigand about 8 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from John Weigand to Parag Mhashilkar

Ready for review.

branch_v2plus_3128 commit: 27d1f75f736389d5c40ea4dbd201f5ac0faa4bf8

File changed:
modified: install/manage-glideins
modified: install/services/Certificates.py
modified: install/services/Condor.py
modified: install/services/Factory.py
modified: install/services/VDT.py
modified: install/services/VDTClient.py
modified: install/services/VOFrontend.py
modified: install/services/common.py
modified: lib/subprocessSupport.py

Modified the ini installer to use the new subprocessSupport.py module in
place of the deprecated commands, system, spawn and popen python modules.

The subprocessSupport.py module was also modfied for the following:
1. additional useShell argument in the method to allow the command to be
executed through the shell. This was needed in the cases where pipes,
wildcards and other shell features were needed. It previously was set
to False thus not allowing this capability. Added to the doc for this.

2. Fixed a minor problem with the calling of the CalledProcessError
Exception where the exitStatus was always being changed to zero.

3. Also fixed a minor problem in the CalledProcessError class where it
never output stderr from the call.

Note: the q/a installer was not modified at this time.
A separate ticket should be generated for this.

#3 Updated by Parag Mhashilkar almost 8 years ago

  • Assignee changed from Parag Mhashilkar to John Weigand

Looks ok to merge

#4 Updated by John Weigand over 7 years ago

Merged into branch_v2plus and tested.
hash: 27d1f75f736389d5c40ea4dbd201f5ac0faa4bf8

Had made additional changes for the paths on imports.

Still have master branch to do.

John Weigand

#5 Updated by John Weigand over 7 years ago

Corrected pylint error in Condor.py
in branch_v2plus_3128.
hash: acdf0b60441744927b09ee2bf5261f42ebe5a9a5

Merged into branch_v2plus

John Weigand

#6 Updated by John Weigand over 7 years ago

  • Status changed from Feedback to Resolved

Changes cherry-picked into master
hash: 4a0c4dce1120c9fa6074fbe9ecac42ff11c1eded

The lib/subprocessSupport.py was added to the master with the
commit. The original add in v2plus was done back in June 2012
but apparently have not yet been merged into the master branch.
This should not present any problems as there were no basic
changes to the original code. Just some fixes and an optional
additional argument in the call.

John Weigand

#7 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from v2_7_x to v2_7

#8 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF