Project

General

Profile

Bug #3057

Remove isRealData instances from checks for MCTruth

Added by Gavin Davies about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
10/19/2012
Due date:
11/01/2012
% Done:

0%

Estimated time:
Duration: 14

Description

Anything that can run on data and MC should not be looking at the isRealData flag.
Chris will make a simple function one can ask BackTracker service if there is Truth present.

Will press on different package developers to make the necessary changes/removal of isRealData flag check

Goal: To have this resolved for next round of production

History

#1 Updated by Gavin Davies about 7 years ago

OK, whilst writing the ticket Chris made the BackTracker function: https://cdcvs.fnal.gov/redmine/projects/novaart/repository/revisions/3703

New function HaveTruthInfo(). Should replace most uses of evt.isRealData().

#2 Updated by Christopher Backhouse about 6 years ago

Hall of shame, to be investigated, found using ack:

  • Calibration (I think we're mostly using this as a proxy for whether or not we should sum planes by view)
  • Filter
  • MCCheater
  • MCCheckOut
  • MuonRemove
  • NuMISpillInfo
  • RecoJMShower
  • ShowerAna

Some of these might be OK. Others pretty definitely not.

#3 Updated by Christopher Backhouse over 5 years ago

Updated list:

  • CAFMaker - to fill the metadata. That's probably OK
  • Calibration - "expert" use, probably OK
  • Filter - this should be using the BackTracker function
  • IFDBSpillInfo - I think this is OK
  • MCCheater - this is OK
  • MCCheckOut - should use the BackTracker function
  • RecoJMShower - All over the place. We shouldn't be switching on data/MC at all for a PID!
  • ShowerAna - should use the BackTracker function
  • ShowerLID - Same comments for RecoJM

Looks like we could close this with a little work, only two years behind schedule

#4 Updated by Kanika Sachdev over 5 years ago

  • Status changed from New to Closed

I've fixed all but RecoJMShower. The use of isRealData there goes too deep. Since it is going to get retired soon anyway, I don't think it's worth spending the time.



Also available in: Atom PDF