Project

General

Profile

Feature #2981

Pull Request: improved frontendGroupGraphStatusNow

Added by Derek Weitzel about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Parag Mhashilkar
Category:
-
Target version:
Start date:
10/03/2012
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

I have incorporated the twitter / bootstrap theme into the monitoring page. A demo can be found at Nebraska

Below is the pull request:
The following changes since commit 15c43021aa6caabf5aac2e38d84aabfea43da604:

Merge branch 'branch_v2plus_2952' into branch_v2plus (2012-10-03 10:51:25 -0500)

are available in the git repository at:

git://github.com/djw8605/glideinWMS.git twitter-groupgraph

Derek Weitzel (1):
Modify the Group Graphs page to use the twitter / bootstrap theme consistent with MyOSG and the OSG's OIM.

creation/web_base/frontendGroupGraphStatusNow.html |  130 +++++++++++++----
1 files changed, 102 insertions(+), 28 deletions(-)

History

#1 Updated by Derek Weitzel about 7 years ago

I added more to the pull request. I modified the page further to meet the style of bootstrap / twitter theme. Demo is still at Nebraska.

New pull request:
The following changes since commit 15c43021aa6caabf5aac2e38d84aabfea43da604:

Merge branch 'branch_v2plus_2952' into branch_v2plus (2012-10-03 10:51:25 -0500)

are available in the git repository at:

git://github.com/djw8605/glideinWMS.git twitter-groupgraph

Derek Weitzel (2):
Modify the Group Graphs page to use the twitter / bootstrap theme consistent with MyOSG and the OSG's OIM.
More changes to the group graphs to reflect the style of twitter/bootstrap.

creation/web_base/frontendGroupGraphStatusNow.html |  182 +++++++++++++-----

#2 Updated by Derek Weitzel about 7 years ago

Ok, made more changes. Updated the navbar to be standard across the frontend index and the group graphs. And Updated the index to be consistent with twitter/bootstrap style.

EDIT: Forgot to include demos.
Group Graphs
Frontend Index

The following changes since commit 15c43021aa6caabf5aac2e38d84aabfea43da604:

Merge branch 'branch_v2plus_2952' into branch_v2plus (2012-10-03 10:51:25 -0500)

are available in the git repository at:

git://github.com/djw8605/glideinWMS.git twitter-groupgraph

Derek Weitzel (3):
Modify the Group Graphs page to use the twitter / bootstrap theme consistent with MyOSG and the OSG's OIM.
More changes to the group graphs to reflect the style of twitter/bootstrap.
Updating the frontend index page to twitter/bootstrap and standardize nav bar.

creation/web_base/frontend/index.html              |  150 ++++++---------
creation/web_base/frontendGroupGraphStatusNow.html | 179 +++++++++++++-----
2 files changed, 200 insertions(+), 129 deletions(-)

#3 Updated by Parag Mhashilkar about 7 years ago

  • Target version set to v2_7_x

#4 Updated by Burt Holzman about 7 years ago

  • Assignee set to Burt Holzman

#5 Updated by Derek Weitzel almost 7 years ago

Updated pull request:

The following changes since commit:3db9bbd474206d19b89e9380c0307ce1c099322e:

Release v2_6_3_rc2 (2012-12-19 14:37:16 -0600)

are available in the git repository at:
git://github.com/djw8605/glideinWMS.git twitter-groupgraph

Derek Weitzel (6):
Modify the Group Graphs page to use the twitter / bootstrap theme consistent with MyOSG and the OSG's OIM.
More changes to the group graphs to reflect the style of twitter/bootstrap.
Updating the frontend index page to twitter/bootstrap and standardize nav bar.
Adding page-header to the page title of the group graphs
Fixing typo in the navbar, glidein not glidien.
Fixing left group menu borders in frontendGroupGraphStatusNow.html

creation/web_base/frontend/index.html              |  150 +++++---------
creation/web_base/frontendGroupGraphStatusNow.html | 181 +++++++++++++-----
2 files changed, 202 insertions(+), 129 deletions(-)

#6 Updated by Burt Holzman almost 7 years ago

  • Status changed from New to Feedback
  • Assignee changed from Burt Holzman to Krista Larson

This was very long-overdue for a pull. Derek's changes should be cosmetic for the web interface. Krista, could we try this out on one of our FEs and make
sure everything looks OK before we merge into branch_v2plus?

#7 Updated by Krista Larson almost 7 years ago

Here's them on the production frontend at FNAL:
http://cmssrv119.fnal.gov:8319/vofrontend/monitor/frontend_srv119-v1/frontendGroupGraphStatusNowDerek2.html
http://cmssrv119.fnal.gov:8319/vofrontend/monitor/frontend_srv119-v1/indexDerek.html

The index page looks good but I thought it was a little weird the the order of the top menu is not the same as the order of the links in the main part.

I'm not getting some of the graphs to show up in the status page. Maybe this version is missing the changes Parag made so it will be ok after it's merged to v2plus? Also you can no longer click to enlarge the graph.

#8 Updated by Derek Weitzel almost 7 years ago

The index page looks good but I thought it was a little weird the the order of the top menu is not the same as the order of the links in the main part.

The order on the top is the same on both the index and the group page. Do you mean the order is different on the top of the index page vs the giant icons in the middle of the page?

I'm not getting some of the graphs to show up in the status page. Maybe this version is missing the changes Parag made so it will be ok after it's merged to v2plus?

Yes, this version does not have the fix to remove the down entries. Should be fixed in the merge.

Also you can no longer click to enlarge the graph.

Correct, I disabled this feature. Is it something that would be nice to have?

#9 Updated by Krista Larson almost 7 years ago

Yes, in the index page I was talking about the giant icons in the middle of the page. It was just for consistency with the menu bar at the top.

Enlarging is nice but you can get the same effect from zooming in or out. I just wanted to make sure that it was not broken because I was using a different browser or something.

#10 Updated by Parag Mhashilkar almost 7 years ago

  • Target version changed from v2_7_x to v2_7

#11 Updated by Derek Weitzel almost 7 years ago

Ok, updated index page. New pull request (this thing is getting long):

The following changes since commit 127bf3fabefec44489d0febaf0be2845885e91e1:

Merge branch 'branch_v2plus_igor_3101' into branch_v2plus (2013-01-03 12:08:24 -0800)

are available in the git repository at:

git://github.com/djw8605/glideinWMS.git twitter-groupgraph

Derek Weitzel (7):
Modify the Group Graphs page to use the twitter / bootstrap theme consistent with MyOSG and the OSG's OIM.
More changes to the group graphs to reflect the style of twitter/bootstrap.
Updating the frontend index page to twitter/bootstrap and standardize nav bar.
Adding page-header to the page title of the group graphs
Fixing typo in the navbar, glidein not glidien.
Fixing left group menu borders in frontendGroupGraphStatusNow.html
Changing order on the index page to reflect the nav bar order.

creation/web_base/frontend/index.html              |  150 +++++---------
creation/web_base/frontendGroupGraphStatusNow.html | 181 +++++++++++++-----
2 files changed, 202 insertions(+), 129 deletions(-)

#12 Updated by Derek Weitzel almost 7 years ago

Yet more changes, and a new updated pull request:

The following changes since commit 127bf3fabefec44489d0febaf0be2845885e91e1:

Merge branch 'branch_v2plus_igor_3101' into branch_v2plus (2013-01-03 12:08:24 -0800)

are available in the git repository at:

git://github.com/djw8605/glideinWMS.git twitter-groupgraph

Derek Weitzel (8):
Modify the Group Graphs page to use the twitter / bootstrap theme consistent with MyOSG and the OSG's OIM.
More changes to the group graphs to reflect the style of twitter/bootstrap.
Updating the frontend index page to twitter/bootstrap and standardize nav bar.
Adding page-header to the page title of the group graphs
Fixing typo in the navbar, glidein not glidien.
Fixing left group menu borders in frontendGroupGraphStatusNow.html
Changing order on the index page to reflect the nav bar order.
Updating groupgraphs with Parag's comments.

creation/web_base/frontend/index.html              |  150 +++++---------
creation/web_base/frontendGroupGraphStatusNow.html | 194 +++++++++++++-----
2 files changed, 211 insertions(+), 133 deletions(-)

#13 Updated by Parag Mhashilkar almost 7 years ago

I pulled latest changes and they are now in our gitrepo in branch_v2plus_2981

#14 Updated by Igor Sfiligoi almost 7 years ago

Could we get the displayed group specified as part of the URL?

E.g. like we can with the others?
http://glidein-frontend.t2.ucsd.edu:8319/vofrontend/monitor/frontend_UCSD-v5_4/frontendStatus.html?group=main

#15 Updated by Igor Sfiligoi almost 7 years ago

BTW: Why does't this page have a "Total" group, like everything else?

That should also be the default.

#16 Updated by Derek Weitzel almost 7 years ago

Adding commit to add group to the url.

Adding a 'Totals' to the page will require much more work. Probably should open a separate ticket.

The following changes since commit 127bf3fabefec44489d0febaf0be2845885e91e1:

Merge branch 'branch_v2plus_igor_3101' into branch_v2plus (2013-01-03 12:08:24 -0800)

are available in the git repository at:

git://github.com/djw8605/glideinWMS.git twitter-groupgraph

Derek Weitzel (9):
Modify the Group Graphs page to use the twitter / bootstrap theme consistent with MyOSG and the OSG's OIM.
More changes to the group graphs to reflect the style of twitter/bootstrap.
Updating the frontend index page to twitter/bootstrap and standardize nav bar.
Adding page-header to the page title of the group graphs
Fixing typo in the navbar, glidein not glidien.
Fixing left group menu borders in frontendGroupGraphStatusNow.html
Changing order on the index page to reflect the nav bar order.
Updating groupgraphs with Parag's comments.
Adding group to the url, allowing link sharing.

creation/web_base/frontend/index.html              |  150 +++-------
creation/web_base/frontendGroupGraphStatusNow.html | 252 ++++++++++++++----
2 files changed, 269 insertions(+), 133 deletions(-)

#17 Updated by Derek Weitzel almost 7 years ago

Ok, I'm done attaching the pull-requests. Getting too big.

Anyways, I got the back / forward buttons working when navigating the groups. Pull again:

git://github.com/djw8605/glideinWMS.git twitter-groupgraph

#18 Updated by Parag Mhashilkar almost 7 years ago

I pulled latest changes and they are now in our gitrepo in branch_v2plus_2981

#20 Updated by Derek Weitzel almost 7 years ago

Yet another (smallish) update. Added tabs as pointed out on #3224.

New Commit: https://github.com/djw8605/glideinWMS/commit/022fc3e2ce922ea912ccf67c10ecf410c781ab7e

git pull git://github.com/djw8605/glideinWMS.git twitter-groupgraph

#22 Updated by Igor Sfiligoi almost 7 years ago

Why tabs, and not a different page?

We already have multiple pages.

#23 Updated by Derek Weitzel almost 7 years ago

Hi Igor,

I like the tabs because the data shown in the two tabs corresponds to each other. Another page would imply that we are looking at different data, when we are not. It's the same data, just the table gives a different view.

#24 Updated by Parag Mhashilkar almost 7 years ago

Derek Weitzel wrote:

Hi Igor,

I like the tabs because the data shown in the two tabs corresponds to each other. Another page would imply that we are looking at different data, when we are not. It's the same data, just the table gives a different view.

Thats the exact reason for making tabs. Same data different representation.

#25 Updated by Parag Mhashilkar almost 7 years ago

Pull from github, merged and pushed code for tabs into repo

#26 Updated by Parag Mhashilkar almost 7 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Krista Larson to Parag Mhashilkar

Merged the changes to branch_v2plus & manually merged into master

#27 Updated by Parag Mhashilkar over 6 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF