Project

General

Profile

Bug #2947

Fhicl allows creation of new parameters in the configuration in the job file

Added by Denis Perevalov about 7 years ago. Updated almost 7 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
09/10/2012
Due date:
% Done:

0%

Estimated time:
Occurs In:
Scope:
Internal
Experiment:
-
SSI Package:
Duration:

Description

I'll try to explain the problem with a simple example.

Let's say I have a header fcl file with some standard configuration

BEGIN_PROLOG
my_standard: {
module_type: MyModule
ParA: 12
ParB: [ "filename" ]
}
END_PROLOG

Now in my job fcl I would like to overwrite one of the parameters in that parameter set. Suppose I mistype the name ParA, then it would be still valid. For example, like this,

#include "job/my_header.fcl"
physics: {
producers: {
generator: @local::my_standard
}
}

physics.producers.generator.ParamA: 13

If I run the job with this fcl, everything will be fine. I asume that after this, the parameter set consists of three variables: ParA, ParB and ParamA. I think we should not allow a new parameter to be made on the fly like this. We should allow only existing parameters to be overwritten outside of BEGIN_PROLOG/END_PROLOG. Or at least you can produce a HUGE warning in there once it happens.

My student got burned a couple of times by this, because he either mistyped parameter name or put "geometry" instead of "generator" in there. And it's hard to track down, because it looks fine visually and the program runs, it's just nothing gets changed from default.

History

#1 Updated by Marc Paterno almost 7 years ago

  • Status changed from New to Rejected

The experiments have agreed that no action is to be taken.



Also available in: Atom PDF