Project

General

Profile

Bug #2855

art_make() on a directory with only modules fails

Added by Adam Lyon almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
07/28/2012
Due date:
% Done:

100%

Estimated time:
0.20 h
Spent time:
Duration:

Description

If you run art_make() [no arguments] on a directory that only has modules (no non-module code), CMake fails with a incorrect number of arguments error.

Here's why.
"art_make()" has no library dependencies (the modules obviously can't do much, but they are just educational), so the art_liblist variable is never set. Later in the code, _art_simple_plugin is called, but this requires the liblist argument, which is undefined. Hence the error.

Easy fix:
At the top of art_make, just below "set (art_file_list ""), add "set(art_liblist FALSE)". If LIBRARIES is passed in, then they will replace FALSE. If not, then FALSE is passed as the liblist to _art_simple_plugin and eventually to simple_plugin where FALSE causes the if statement regarding the liblist to be false and so it correctly does not run its body.

History

#1 Updated by Lynn Garren almost 8 years ago

  • Assignee set to Lynn Garren
  • % Done changed from 0 to 100
  • Estimated time set to 0.20 h

#2 Updated by Lynn Garren almost 8 years ago

  • Status changed from New to Resolved

#3 Updated by Christopher Green almost 8 years ago

  • Target version set to 1.01.01

#4 Updated by Christopher Green almost 8 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF