Project

General

Profile

Bug #2851

Factory install still not cleaning dirs/files correctly on re-install

Added by John Weigand over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Weigand
Category:
Ini-Installer
Target version:
Start date:
07/26/2012
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

The ini installer is still not cleaning the directories and files
correctly on a re-install.

History

#1 Updated by John Weigand over 7 years ago

  • Status changed from New to Feedback

Ready for review. commit:ce50f78

#2 Updated by Burt Holzman over 7 years ago

  • Assignee changed from John Weigand to Parag Mhashilkar

#3 Updated by Parag Mhashilkar over 7 years ago

  • I see pieces of code that are irrelevant and do same thing
    verify_ps_directories_empty(dirs) & verify_nps_directories_empty(dirs) do exactly same set of tests just in different order. You just need one that screens out empty directories. verify_empty_directories().
  • Once you replace above with a single function if statement becomes irrelevant
    if self.wms.privilege_separation() == "y":
  • Similarly, if statement below the comment "#--- double check them --" will be irrelevant
  • Why make user wait 3 secs with os.system("sleep 3")? Are you afraid of any synchronization issues?

#4 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Parag Mhashilkar to John Weigand

#5 Updated by John Weigand over 7 years ago

  • Assignee changed from John Weigand to Parag Mhashilkar

Commit hash: a25c047 Branch: branch_v2plus_2851

1. Combined verify_ps_directories and verify_nps_directories into a
single verify_directories eliminating the conditional.

2. Left the "double check" in place as it does not hurt anything and
does allow for a secondary validation before proceeding.

3. Kept the sleep. Its purpose, and there are several more in the code,
is to slow down the scrolling of the output allowing the user to
actually see what occurred. There are no synchonization issues
associated with it. Just user friendliness. It is an install,
not a production process and therefore does not require being
all that efficient.

John Weigand

#6 Updated by John Weigand over 7 years ago

  • Status changed from Assigned to Feedback

#7 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Parag Mhashilkar to John Weigand

Looks ok to me. Feel free to merge and resolve the ticket.

John Weigand wrote:

3. Kept the sleep. Its purpose, and there are several more in the code,
is to slow down the scrolling of the output allowing the user to
actually see what occurred. There are no synchonization issues
associated with it. Just user friendliness. It is an install,
not a production process and therefore does not require being
all that efficient.

John Weigand

Ok. The intent wasn't clear to me when I saw the sleep for first time.

#8 Updated by John Weigand over 7 years ago

  • Status changed from Assigned to Resolved
  • Target version changed from v2_7_x to v2_6_2

Merged into branch_v2plus from branch_v2plus_2851
- Merge: bf2fa3d a25c047

Cherry picked into master
- commit: 5ca814 6fee2c

File: install/services/Factory.py

John Weigand

#9 Updated by Parag Mhashilkar about 7 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF