Project

General

Profile

Idea #2592

Factory attribute parsing may be faulty

Added by Igor Sfiligoi over 7 years ago. Updated over 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
03/22/2012
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

Looking again at how the Factory parses the attributes made me think the logic is less than sound.

cgWParamDict.py

    if do_publish: # publish in factory ClassAd
        if is_parameter: # but also push to glidein
            if is_const:
                dicts['attrs'].add(attr_name,attr_val)
                dicts['consts'].add(attr_name,attr_val)
            else:
                dicts['params'].add(attr_name,attr_val)
        else: # only publish
            if (not is_const):
                raise RuntimeError, "Published attribute '%s' must be either a parameter or constant: %s"%(attr_name,attr_obj)

            dicts['attrs'].add(attr_name,attr_val)
            dicts['consts'].add(attr_name,attr_val)
    else: # do not publish, only to glidein
        if is_parameter:
            if is_const:
                dicts['consts'].add(attr_name,attr_val)
            else:
                raise RuntimeError, "Parameter attributes '%s' must be either a published or constant: %s"%(attr_name,attr_obj)
        else:
            raise RuntimeError, "Attributes '%s' must be either a published or parameters: %s"%(attr_name,attr_obj) 

We should review it and fix it if needed.


Related issues

Related to glideinWMS - Idea #2593: Frontend attribute parsing may be faultyNew2012-03-22

History

#1 Updated by Parag Mhashilkar over 7 years ago

  • Assignee set to Igor Sfiligoi

#2 Updated by Burt Holzman over 7 years ago

  • Target version set to v3_1

#3 Updated by Burt Holzman over 6 years ago

  • Target version changed from v3_1 to v3_x

#4 Updated by Parag Mhashilkar over 4 years ago

  • Assignee deleted (Igor Sfiligoi)

Igor Sfiligoi's tickets. These were some ideas brewing up in his mind but they never materialized or got priority.



Also available in: Atom PDF