Project

General

Profile

Feature #2559

glidein wrapper is not a true wrapper

Added by Igor Sfiligoi over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Low
Assignee:
Douglas Strain
Category:
-
Target version:
Start date:
03/14/2012
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

Dan B. just found out that the glidein wrapper is not a real wrapper;
it is just a way to run a few commands before the the actual job... but one cannot influence how the job is executed.
He instead needs to launch the job inside parrot!

Here is the offending code:
sfiligoi@mynode:glideinWMS/creation/web_base$ less condor_startup.sh

cat >> $condor_job_wrapper <<EOF

# Condor job wrappers must replace its own image
exec "\$@" 
EOF

What he needs instead is

exec "$GLIDEIN_PARROT/parrot_run" -t "$parrot_tmp" "$@" 

History

#1 Updated by Igor Sfiligoi over 8 years ago

Here is my take on how to fix it:
We define a variable, say
GLIDEIN_WRAPPER_EXEC
and initialize it to

"\@" 

and condor_startup.sh then runs

exec $GLIDEIN_WRAPPER_EXEC

instead.
(PS: I am not sure about the proper escaping right now, but should be doable)

The user-provided wrappers then can change that env variable, thus building it piecemeal if needed.

Any objections going this path?

#2 Updated by Burt Holzman over 8 years ago

  • Assignee set to Parag Mhashilkar

No objections here -- not urgent.

#3 Updated by Burt Holzman over 8 years ago

  • Target version changed from v2_5_7 to v2_7_x

#4 Updated by Parag Mhashilkar over 8 years ago

  • Priority changed from Normal to Low

#5 Updated by Douglas Strain about 8 years ago

  • Assignee changed from Parag Mhashilkar to Douglas Strain

#6 Updated by Douglas Strain about 8 years ago

  • Status changed from New to Feedback
  • Assignee changed from Douglas Strain to Parag Mhashilkar

I have implemented things very closely to Igor's suggestion to add a variable GLIDEIN_WRAPPER_EXEC that affects the condor_job_wrapper. Changes are in branch_v2plus_2559:

a79012817647861f88df07435458d16858251813 Feature 2559: GLIDEIN_WRAPPER_EXEC documentation
200c073fa7d314b58129e8c296b9eb7d77f5dbec Feature 2559: glidein wrapper is now configurable as a variable

This is low priority but a small change, so review when you get a chance.

#7 Updated by Parag Mhashilkar about 8 years ago

  • Assignee changed from Parag Mhashilkar to Douglas Strain

Looks ok to me. Feel free to merge

#8 Updated by Douglas Strain about 8 years ago

  • Status changed from Feedback to Resolved

Merged into branch_v2plus and master

#9 Updated by Parag Mhashilkar almost 8 years ago

  • Target version changed from v2_7_x to 293

#10 Updated by Parag Mhashilkar over 7 years ago

  • Target version changed from 293 to v2_7

#11 Updated by Parag Mhashilkar over 7 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF