Project

General

Profile

Bug #25570

IDTOKENS doesn't work with condor 8.9.10 or later

Added by Brian Bockelman about 2 months ago. Updated 16 days ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
03/01/2021
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

It appears that version comparison is done against the string '8.9.2' and, of course, when done this way the string '8.9.2' is greater than '8.9.10'.

Brian Lin mentioned a similar bug existing for the SciTokens version detection - perhaps the same fix applies here as well?

Associated revisions

Revision 7ab31e80 (diff)
Added by Dennis Box about 2 months ago

fix for #25570 condor version comparison fails for condor 8.9.10
or later.

History

#1 Updated by Marco Mambelli about 2 months ago

  • Target version set to v3_7_3
  • Priority changed from Normal to High
  • Assignee set to Dennis Box

#2 Updated by Dennis Box about 2 months ago

  • Assignee changed from Dennis Box to Bruno Coimbra
  • Status changed from New to Feedback

please see branch v37/25570, diff with branch_v3_7 for review

#3 Updated by Bruno Coimbra 23 days ago

  • Assignee changed from Bruno Coimbra to Dennis Box

The changes look good. The only remark that I make is that we're still using string comparisons, which would cause a similar issue should condor ever reach 8.10.
As we discussed with Brian at our development meeting, a tuple comparison could be a better approach.

#4 Updated by Dennis Box 16 days ago

  • Status changed from Feedback to Resolved

version comparison was taken completely out in 3.7.3 so this fix no longer applies.
GWMS frontend now supplies idtokens for glideins efficiently and in-line, if the condor tarball
used by the glidein doesn't support it the glidein falls back to GSI authentication

SciTokens are supplied by the frontend either globally or per-group. If supplied, the factory tries to authenticate with the CE using the scitoken, if this fails, authentication falls back to GSI

Also available in: Atom PDF