Project

General

Profile

Feature #25477

Add layer to account for pilot entries in OSG_autoconf

Added by Marco Mascheroni 3 months ago. Updated 11 days ago.

Status:
Resolved
Priority:
Normal
Category:
Configuration Management
Target version:
Start date:
02/05/2021
Due date:
% Done:

0%

Estimated time:
Stakeholders:

Factory Ops

Duration:

Description

OSG introduced a new osg configure layer that allows HTCondorCE site admins to specify pilot configurations (see https://opensciencegrid.atlassian.net/browse/SOFTWARE-4177)

We should adapt OSG_autoconf to address this.

History

#1 Updated by Marco Mascheroni 3 months ago

  • Assignee changed from Marco Mascheroni to Marco Mambelli
  • Status changed from New to Feedback

#2 Updated by Marco Mambelli 2 months ago

  • Stakeholders updated (diff)
  • Assignee changed from Marco Mambelli to Marco Mascheroni

Feedback sent on 2/5 via email, forgot to change the status here, repeating it here:

Hi Marco,

* factory/tools/OSG_autoconf.py

The model is set, CE, queue, entry, correct?

                               if want_whole_node is True or want_whole_node == "True":
-->
the type can change? should then be better to have a function def isTrue(in): ?  
to be consistent w/ similar boolean variables

       logging.exception("")
       print("\033[91mUnexpected exception. Aborting automatic configuration generation!\033[0m")
       raise
-->
why printing the empty message? Just to have the stack trace?

* config_util.py
   if limits is not None:
...
using is not None for limits and value because it is OK an empty value?
I like the fact that is more specific, but makeing sure that it is what you want

Cheers,
Marco

#3 Updated by Marco Mambelli 11 days ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF