Project

General

Profile

Feature #25436

Extend gwms-logcat.sh to extract other log files (startd slots and extra ones)

Added by Marco Mambelli about 1 month ago. Updated 18 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marco Mambelli
Category:
-
Target version:
v3_6_7
Start date:
01/25/2021
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

Extend gwms-logcat.sh to extract other log files like the startd of individual slots and extra files, using their name.

Also fix the option to print all log files (was not working)

History

#1 Updated by Marco Mambelli about 1 month ago

  • Assignee changed from Marco Mambelli to Bruno Coimbra
  • Status changed from New to Feedback

Changes are in v36/25436

#2 Updated by Bruno Coimbra 21 days ago

Marco, here are just a couple of points I noticed:

factory/tools/cat_named_log.py

  • This is more a question than an issue: why not use argparse to handle the script arguments?
  • Do we need to keep this section commented in the code?
    # matches = gWftLogParser.get_StarterSlotNames(fname)
# if len(matches):
#    logs = ', '.join(matches)
#    print("StarterLogs available for slots: %s" % logs.replace('StarterLog.', ''))
# print(gWftLogParser.get_CondorLog(fname, condor_log_id))

factory/tools/gwms-logcat.sh

  • [Line 275] Shellcheck recommends: Use $(...) notation instead of legacy backticked

#3 Updated by Bruno Coimbra 21 days ago

  • Assignee changed from Bruno Coimbra to Marco Mambelli

#4 Updated by Marco Mambelli 18 days ago

  • Status changed from Feedback to Resolved

I was not sure whether to print the list of starter logs (which are variable). I decided not to, and I removed the comment.
For one single optional parameter, it's easier to handle it directly (no argparse).

Applied most shellcheck suggestions, including the one pointed out

Also available in: Atom PDF