Project

General

Profile

Feature #25325

Improve GitHub actions not to fail pycodestyle all the times

Added by Marco Mambelli 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
Start date:
12/16/2020
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

There are multiple pycodestyle warnings.
The desired behavior is to fail the github action only if there is an increase in warnings (or if they are more than the best branch)


Related issues

Blocks GlideinWMS - Milestone #25335: Improve CI/CD using GitHub toolsNew12/17/2020

History

#1 Updated by Marco Mambelli 2 months ago

  • Assignee changed from Marco Mambelli to Bruno Coimbra
  • Status changed from New to Feedback

Changes are in v36/25325

The test fails if the number of warnings is bigger than the minimum number of warnings in the project.

#2 Updated by Marco Mambelli 2 months ago

#3 Updated by Bruno Coimbra 2 months ago

  • Assignee changed from Bruno Coimbra to Marco Mambelli

pycodestyle.yaml
- Lines 34, 68, and 100 have trailing spaces. Not a show stopper, in my opinion, we could even leave it there until further changes are required on the file.

Everything else looks fine.

#4 Updated by Marco Mambelli 2 months ago

  • Status changed from Feedback to Resolved

Removed the extra spaces and merged to master

Also available in: Atom PDF