Project

General

Profile

Necessary Maintenance #25311

Discuss and remove legacy code in MainWindow::bDAQInterfacePressed()

Added by Iker de Icaza Astiz 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Start date:
12/11/2020
Due date:
% Done:

100%

Estimated time:
Duration:

Description

There's this chunk of commented code that we could remove now. But it would be better to discuss if the current working way is the best approach, or if we can go back or use some of this commented code.

MainWindow::bDAQInterfacePressed()

  // QStringList daqinterface_start_commands;

  // qDebug() << "All env variables:";
  // QString env_variable;
  // QStringList paths_list = env.toStringList();
  // foreach( env_variable, paths_list ) qDebug() << env_variable;

  // //////// old way
  // daqinterface_start_commands << "stdbuf -oL ./rc/control/daqinterface.py --partition-number" 
  //                             << partition_number_str
  //                             << "--rpc-port" << rpc_port_str;
  // daq_interface.start(daqinterface_start_commands.join(" "));
  // //////// old way

  // //////// estebans way; sadly not working
  // daqinterface_start_commands << "stdbuf -oL" << wd + "/rc/control/daqinterface.py --partition-number" 
  //                            << partition_number_str
  //                            << "--rpc-port" << rpc_port_str;
  // DAQInterfaceProcess_started = daq_interface.startDetached(daqinterface_start_commands.join(" "));
  // DAQInterface_PID = daq_interface.processId();
  // setButtonsDAQInterfaceInitialized(DAQInterfaceProcess_started);
  // qDebug() << daqinterface_start_commands;
  // //DAQInterface_logfile = "/home/ecristal/Debug.log";
  // //DAQInterface_logwatcher.addPath(DAQInterface_logfile);

  // //////// estebans way

Related issues

Blocks ArtDaq RunControl GUI - Milestone #25316: v1_02_00Resolved12/14/2020

History

#1 Updated by Iker de Icaza Astiz 3 months ago

#2 Updated by Iker de Icaza Astiz 3 months ago

#3 Updated by Iker de Icaza Astiz 3 months ago

#4 Updated by Iker de Icaza Astiz 3 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Resolved

Esteban and I had a discussion about this. The current approach which calls DAQInterface.sh is the best, and it works. So we keep it and remove the legacy code.

Commit 39bdb9fb4 has this. Resolved.

#5 Updated by Iker de Icaza Astiz 3 months ago

  • Status changed from Resolved to Closed

Nothing else to do. Closing.

Also available in: Atom PDF