Project

General

Profile

Necessary Maintenance #25259

MainWindow::closeProgram() is way too excessive

Added by Iker de Icaza Astiz about 2 months ago. Updated 12 days ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Start date:
11/26/2020
Due date:
% Done:

100%

Estimated time:
Duration:

Description

As it stands MainWindow::closeProgram() kill everything. Let's limit that behaviour and make it exit more gracefully.


Related issues

Blocks ArtDaq RunControl GUI - Milestone #25316: v1_02_00Resolved12/14/2020

History

#1 Updated by Esteban Cristaldo about 1 month ago

  • % Done changed from 0 to 90
  • Status changed from New to Feedback

In Revision #dd2d88ac, the close program behaviour was change in order to make the GUI exit without killing other instances of DAQInterface. Also, the User needs to end the DAQInterface session in the 'Stopped' state in order to close the program properly.

#2 Updated by Esteban Cristaldo about 1 month ago

changes located in branch 'test/icarus_test01'

#3 Updated by Iker de Icaza Astiz about 1 month ago

That branch has a few commits unrelated to this issue. Also commits that I won't merge.

I've assumed you meant to have 607810da as part of this issue as well. I've cherry picked it into branch maintenance/close_program I'll review this last one.

#4 Updated by Iker de Icaza Astiz about 1 month ago

  • % Done changed from 90 to 100
  • Status changed from Feedback to Resolved

I've clean up a bit and simplify the if/else in closeProgram()

I've tested this, it seems to work fine. Marking this as resolved and merging to develop, will leave it open for a while in case any issues is brought up.

#5 Updated by Iker de Icaza Astiz about 1 month ago

#6 Updated by Iker de Icaza Astiz about 1 month ago

#7 Updated by Iker de Icaza Astiz about 1 month ago

#8 Updated by Iker de Icaza Astiz 12 days ago

  • Status changed from Resolved to Closed

Included in latest release.

Closing.

Also available in: Atom PDF