Project

General

Profile

Support #25218

restructure larrecodnn

Added by Lynn Garren 5 months ago. Updated 4 months ago.

Status:
Assigned
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
11/17/2020
Due date:
% Done:

50%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

larrecodnn has optional dependencies on tensorflow and trtis_clients. It should be possible to build for either trtis_clients or tensorflow. However, all trtis_clients interfaces are found under larrecodnn/ImagePatternAlgs/Tensorflow. This means that tensorflow is required at all times.

We request that the trtis_clients interface be moved into its own independent subdirectory at same level as the Tensorflow subdirectory.

History

#1 Updated by Michael Wang 5 months ago

Here is my proposal on how to restructure things. I will first show the current structure followed by the proposed structure. I didn't include every file, only those that are relevant or will be moved. Files that are not indicated will remain in whatever subdirectory they are currently in. It is assumed that if those subdirectories are moved, those files will move with them. Please let me know what you think.

=================
CURRENT STRUCTURE:
=================

larrecodnn
  |
  +-ImagePatternAlgs
      |
      +- job
      |
      +- scripts
      |
      +- Keras
      |
      +- Tensorflow
           |
           +- Modules
           |
           +- TF
           |
           +- PointIdAlg
           |
           +- PointIdAlgTools
           |    |
           |    +- IPointIdAlg.h
           |    |
           |    +- PointIdAlgKeras_tool.cc 
           |    |
           |    +- PointIdAlgTf_tool.cc 
           |    |
           |    +- PointIdAlgTrtis_tool.cc
           |
           +- WaveformRecogTools
                |
                +- IWaveformRecog.h
                |
                +- WaveformRecogTf_tool.cc
                |
                +- WaveformRecogTrtis_tool.cc

==================
PROPOSED STRUCTURE:
==================

larrecodnn
  |
  +-ImagePatternAlgs
      |
      +- job
      |
      +- scripts
      |
      +- Modules
      |
      +- ToolInterfaces
      |    |
      |    +- IPointIdAlg.h
      |    |
      |    +- IWaveformRecog.h
      |
      +- Keras
      |    |
      |    +- Tools
      |        |
      |        +- PointIdAlgKeras_tool.cc
      |
      +- Triton
      |    |
      |    +- Tools
      |        |
      |        +- PointIdAlgTrtis_tool.cc
      |        |
      |        +- WaveformRecogTrtis_tool.cc
      |
      +- Tensorflow
           |
           +- TF
           |
           +- PointIdAlg
           |
           +- Tools
                |
                +- PointIdAlgTf_tool.cc 
                |
                +- WaveformRecogTf_tool.cc

#2 Updated by Lynn Garren 4 months ago

We approve the new structure. - Erica, Kyle, Lynn

#3 Updated by Kyle Knoepfel 4 months ago

  • % Done changed from 0 to 50
  • Co-Assignees Lynn Garren added

#4 Updated by Michael Wang 4 months ago

I created a pull request last week:

https://github.com/LArSoft/larrecodnn/pull/13

Also available in: Atom PDF