Project

General

Profile

Bug #25207

Can launch a dependency without going to Located

Added by Marc Mengel 2 months ago. Updated 29 days ago.

Status:
Work in progress
Priority:
Normal
Assignee:
Target version:
Start date:
11/13/2020
Due date:
% Done:

0%

Estimated time:
First Occurred:
Scope:
Internal
Experiment:
-
Stakeholders:
Duration:

Description

Currently if we have a database error in wrapup_tasks,we go on and launch the dependencies, etc.
If this happens on the update to Located; we then will launch the same dependency again on the
next wrapup_tasks call.
So to prevent this; we should maybe:

  1. make a second attempt at marking them all located
  2. mark them located in the launch_xxx_if_needed routines if they aren't marked located

Others?

Associated revisions

Revision 77717997 (diff)
Added by Marc Mengel 16 days ago

testing hook for issue #25207

History

#1 Updated by Marc Mengel about 1 month ago

Upon further reflection, maybe we should just not do the launch if the dependency
is not marked located. That way the next wrapup_tasks will pick it up; and if the
database is not writable or something we'll just be piling on.

#2 Updated by Marc Mengel about 1 month ago

  • Target version set to v4_3_0

#3 Updated by Marc Mengel 29 days ago

draft of fix is in aea470e, basically just get the lastest history record for the submission and if it isn't Located, have launch_{recovery,dependencies}_if_needed() return without doing anything.
(except for recoveries if the override is set, that means the user requested it from the GUI, so go ahead).

Factored the get latest history code out into its own routine, since we should be using that query
rather than max(status) to decide where the submission is anyway.

#4 Updated by Marc Mengel 29 days ago

  • Assignee set to Marc Mengel
  • Status changed from New to Work in progress

Also available in: Atom PDF