Project

General

Profile

Task #25142

make valgrind dependency explicit

Added by David Adams about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
10/28/2020
Due date:
% Done:

100%

Estimated time:
Duration:

Description

Recently a code dependency on valgrind was added to dunetpc/dune/DataPrep/Service. The setup of valgrind should be moved from the dunetpc setup script to product_deps.

History

#1 Updated by Thomas Junk about 1 month ago

I just pushed dunetpc/ups/product_deps that includes valgrind v3_14_0 as a dependency, which matches that in the setup script.

Did the new features, i.e. the include of the callgrind header, get included in dunetpc v09_08_00 or earlier releases? Taking the line out of the setup script might break these releases if so. If it's a new feature and Lynn caught it right away, then we're good. I can probably look in the history but David can say when the callgrind include was added.

#2 Updated by David Adams about 1 month ago

No, changes were made after the last release.

#3 Updated by Thomas Junk about 1 month ago

Okay, I updated the setup script not to set up valgrind. I also took the liberty of removing the old larsoft setup step. The old larsoft directory in /cvmfs/fermilab.opensciencegrid.org/larsoft was just a symlink to the new larsoft anyway. I had to reorder the common db insertion in $PRODUCTS to keep it working. Now $PRODUCTS is shorter and the setup script should run faster. Committed to duneutil and published in CVMFS. I made a backup setup_dune_20201028.sh just in case we need to back out this most recent change.

#4 Updated by Thomas Junk about 1 month ago

  • Assignee changed from David Adams to Thomas Junk
  • Status changed from New to Resolved

#5 Updated by Thomas Junk about 1 month ago

  • % Done changed from 0 to 100

#6 Updated by David Adams about 1 month ago

  • Status changed from Resolved to Closed

Thanks Tom. Calls to callgrind seem to be working ok with the new setup. I close this ticket.

Also available in: Atom PDF